From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F1A981D68 for ; Thu, 1 Dec 2016 09:00:21 -0800 (PST) Received: by mail-io0-x22a.google.com with SMTP id a124so433835517ioe.2 for ; Thu, 01 Dec 2016 09:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A5NDWZLm9G7M/XCXIT2jYQZVi4JDEDTAI6GQQBVTQm4=; b=SNmjpLtosfBdW9i8wYwJYMBrn2YJjG39hoSU+bfnKhgI2/eN4QqOduUI12Gn4YI1ne c9qZJ36g2nOZcE/jOqR3gbpc6EyhIA/tKw0wYDx/ayHMUcRoIs8j5DT+zACZuU1orkHd gKvcGBCN3pyIkPGSbpNqTyjFuvAYR5ERlEL5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A5NDWZLm9G7M/XCXIT2jYQZVi4JDEDTAI6GQQBVTQm4=; b=dXI2len2h1QUlXnou/xo4Kkg+T7N1k+lYNyaWKULvz6Z0M+8Z6wttzNN+mbZKOE+vj bdHWixLlX8vp5UxuCJoTLXsiqOHQLheQhJMyku1JbVGuA4J8K/WNKei8CxD9gepfLOv5 rD5yllkKROf108CrSxiQSj7dUYkMnr5DwZRBFrHQiJJdAFR30+O9Y1T80jxIu+nZiEb1 GINHUasLhRvIINrAHBwN8ofkI+xz6+Osu3674zpScqwOuvDFoiuaJVQWoncprx3BzkNL mo4d65ELkzjpFJxqDOAaPiqbOgZTAIPKuV4H2LQvUknNj1l2E4Vt+FdsrzJXBGdyuyej 5FQw== X-Gm-Message-State: AKaTC03k59rbwXrhR7NFnnBTyqMt2oCQOw1Ssy0/4qd5yxk5kAMM5RBQUxSfz2qOtSTFJE1XHL1CV8dtjF/Xfk8Q X-Received: by 10.36.73.207 with SMTP id e76mr33898077itd.63.1480611620326; Thu, 01 Dec 2016 09:00:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.67 with HTTP; Thu, 1 Dec 2016 09:00:19 -0800 (PST) In-Reply-To: <20161201164502.9470-1-leif.lindholm@linaro.org> References: <20161201164502.9470-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 1 Dec 2016 17:00:19 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Sudeep Holla , Andrew Fish , Michael D Kinney Subject: Re: [PATCH] ArmPkg: fix compilation error in ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 17:00:21 -0000 Content-Type: text/plain; charset=UTF-8 On 1 December 2016 at 16:45, Leif Lindholm wrote: > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") > retained an explicit cast on the variable "Buffer" which became > incorrect with the other changes, leading to compilation failures > with some toolchains. Drop the cast. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reported-by: Sudeep Holla > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > > Mike, Andrew - since Ard is on holiday and the fix is trivial, > could either of you give me a Reviewed-by: on this one? > > ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > index acc106b..f4ee9e4 100644 > --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > @@ -142,7 +142,7 @@ DmaMap ( > CopyMem (Buffer, HostAddress, *NumberOfBytes); > } > > - *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress ((UINTN)Buffer)); > + *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress (Buffer)); > Map->BufferAddress = Buffer; > } else { > Map->DoubleBuffer = FALSE; > -- > 2.10.2 >