From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well
Date: Thu, 11 Aug 2016 13:51:12 +0200 [thread overview]
Message-ID: <CAKv+Gu-FTNi00+wvK60mXiKfBsw3bfQT505Dq8SCBCTuPMAmog@mail.gmail.com> (raw)
In-Reply-To: <20160811102559.GW31760@bivouac.eciton.net>
On 11 August 2016 at 12:25, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Aug 11, 2016 at 12:08:15PM +0200, Ard Biesheuvel wrote:
>> This moves the asm files in OpenPlatformPkg to the new ASM_FUNC() macro,
>> which annotates functions in a way that allows the linker to drop code
>> that is not actually used anywhere. It is analogous to -ffunction-sections
>> for GCC.
>>
>> Since there are some cargo culted asm patterns that are very clunky and
>> inefficient, clean those up as well (i.e., LoadConstantToReg())
>
> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks, pushed with a minor tweak to #2 to prevent further breakage
with RVCT (given that the upstream is broken with RVCT to begin with)
--
Ard.
prev parent reply other threads:[~2016-08-11 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:08 [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 1/6] Platforms/BeagleBoard: remove unreferenced Sec.inf module Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 2/6] Platforms/BeagleBoard/BeagleBoardLib: switch to ASM_FUNC() asm macro Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 3/6] Platforms/Styx: remove unused AmdStyxSecLib Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 4/6] Platforms/Styx: switch to ASM_FUNC() asm macro Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 5/6] Platforms/Hisilicon/ArmPlatformLibPv660: " Ard Biesheuvel
2016-08-11 10:08 ` [PATCH 6/6] Platforms/Marvell/Armada70x0Lib: " Ard Biesheuvel
2016-08-11 10:25 ` [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well Leif Lindholm
2016-08-11 11:51 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-FTNi00+wvK60mXiKfBsw3bfQT505Dq8SCBCTuPMAmog@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox