From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D68771A1DED for ; Thu, 11 Aug 2016 04:51:13 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id 38so3586798iol.0 for ; Thu, 11 Aug 2016 04:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GcGm4z3l6YB+iNMJd0WqUYjssXwgap/LXTrfjdKxdEM=; b=f1XbGEKRa+x/wH6ksocDtORnfy7w3QgtsOUMACVjbFNJ7SLNMq+z7JB/n0fbyatZl5 xAQQzZHNnOYXQLjze1uw+reK4HpxiDAAD7tV3ikk93G2Dy8Jg173IRoz5w7qRf1y0SCI EtSuxOi94BEvde9b/Bqb4g/5WxmS5OFJez7vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GcGm4z3l6YB+iNMJd0WqUYjssXwgap/LXTrfjdKxdEM=; b=W3UFSfcNhfvSWtvDeAmz1VE9lCFjvFK08pbErY7ZeIvtlkLczV1RJ+n7HejD4YGygt mk5TRxkN70GkOCPhkVCnZa03OXTyzY7o5T/axwsDzLnn7jbTxqRyCZuuQICzMa3p7DVU YhHJcuvvjFr/VewjWTNJFwoL65kXP+n9BrioB2EbslQ3xDJBt6MDn6H0bpj8Pw2b0d4u zZjb4PnU7vNL0/L7eVuNVOAYEqRnqZZrmt+Nqdc7q1d1nWHx/5sSLOuyzADaui3PJDpt pAaAa6o7BlrQtbORHUQIttg0aNVbprvSH7mL97Etg0IkzSdcsG+55EJWWP2+3QKSkkTO EhuA== X-Gm-Message-State: AEkoouuKUgbKgDKUAxi9a4va/wa7tHtfmNHfSTl1tgYVR5QgR74YvTuIPWcOssQpJrreUlqnzs5StN9YINXdsrDY X-Received: by 10.107.41.67 with SMTP id p64mr10573700iop.130.1470916273206; Thu, 11 Aug 2016 04:51:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 11 Aug 2016 04:51:12 -0700 (PDT) In-Reply-To: <20160811102559.GW31760@bivouac.eciton.net> References: <1470910101-20322-1-git-send-email-ard.biesheuvel@linaro.org> <20160811102559.GW31760@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 11 Aug 2016 13:51:12 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 Subject: Re: [PATCH 0/6] Move to ASM_FUNC() macro, and clean up some asm as well X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 11:51:14 -0000 Content-Type: text/plain; charset=UTF-8 On 11 August 2016 at 12:25, Leif Lindholm wrote: > On Thu, Aug 11, 2016 at 12:08:15PM +0200, Ard Biesheuvel wrote: >> This moves the asm files in OpenPlatformPkg to the new ASM_FUNC() macro, >> which annotates functions in a way that allows the linker to drop code >> that is not actually used anywhere. It is analogous to -ffunction-sections >> for GCC. >> >> Since there are some cargo culted asm patterns that are very clunky and >> inefficient, clean those up as well (i.e., LoadConstantToReg()) > > For the series: > Reviewed-by: Leif Lindholm > Thanks, pushed with a minor tweak to #2 to prevent further breakage with RVCT (given that the upstream is broken with RVCT to begin with) -- Ard.