From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8EE0F210E2A60 for ; Fri, 1 Jun 2018 03:05:38 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id l25-v6so6622756ioh.12 for ; Fri, 01 Jun 2018 03:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MN7qd9Ir00EYWjAjM/qD3li2rQFIX1i+HWhW2aGo0cU=; b=kahmky8FgY2/YP2YgAzm8tybgCoXQDmo7RyiRsampspJ0w3NQ7/3IGWm+MBIX8BgXQ yl7GGpxScgGEEsnOY2/uVkQbF5uajPF9XYRw74I1YxXNvRRYO6s9R5HWUrrn7jWfwCi2 aKYKaZsEJov6agWUSYWUx9O4A9NYt+TtxWIOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MN7qd9Ir00EYWjAjM/qD3li2rQFIX1i+HWhW2aGo0cU=; b=nC3faBtUEzDxu9OxGAZC7T+8d+PHtaHO+eCsORUAulZ/y7gOQb79usiHWx6Z/HVCkQ s4x4KI8zmIfftSl7b/xclhGHpMvbsxyJLUicTk4GlZpF+HJ8kmx6o6WKl7rNnhlgUY+6 5AshITjj3oKVoKac0y97L/Wi7ck8+DXdYQ+l3/6mAFsH4MJN88wQMMEhOyxXOglN5FAX Y+E/4rmE3sSr7E22cAT6Rwzum2p9OiDrU3JemEEdNrH1xNUpuuI+irdZ9DIpakzxCrDB u92znYnrRDezczRuhtS2lZOqyFog33mOYGlJK72ai/bPeIltNx4CTqAs3Ah4xOlD5DjZ JRGQ== X-Gm-Message-State: ALKqPwerhYs32eooKYnyjz9rF/1hLogmDi82FnTDc/9S/m7NQedZeqlF Tj9CdZz8HTzrwiJFouZoLaOA15W2yIU0A4b+KHErZA== X-Google-Smtp-Source: ADUXVKJYNpg6lRKY+aHzkilmH7Mv4wssGg4OHK4QVFfRcflTz9LI6gYxb1SzwtHXbVolMY8Ut5NSnNdoB5WNVAnptwU= X-Received: by 2002:a6b:dd0b:: with SMTP id f11-v6mr4033499ioc.173.1527847537385; Fri, 01 Jun 2018 03:05:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 03:05:36 -0700 (PDT) In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB5009F@shsmsx102.ccr.corp.intel.com> References: <20180531090149.29202-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BB5009F@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 1 Jun 2018 12:05:36 +0200 Message-ID: To: "Zeng, Star" , "Yao, Jiewen" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 10:05:38 -0000 Content-Type: text/plain; charset="UTF-8" On 31 May 2018 at 11:12, Zeng, Star wrote: > It could be reused by platform SystemFirmwareDescriptor, for example. > Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > > So, I agree this patch, Reviewed-by: Star Zeng . > > Please also get Jiewen's RB for the patch. > @Jiewen, any comments? Thanks, Ard. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Thursday, May 31, 2018 5:02 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; leif.lindholm@linaro.org; Ard Biesheuvel > Subject: [edk2] [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion > > Add a PCD that holds the lowest supported version number, so that we can allow the platform to configure this at build time. > > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > As discussed a while ago: > https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html > > SignedCapsulePkg/SignedCapsulePkg.dec | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec b/SignedCapsulePkg/SignedCapsulePkg.dec > index b27e87409b19..f06e07656de9 100644 > --- a/SignedCapsulePkg/SignedCapsulePkg.dec > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec > @@ -52,6 +52,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt GUID of the FFS which contains the Pkcs7TestPublicKeyFile. > gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xba, 0xf5, 0x93, 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, 0xf7, 0xe0, 0xb8}|VOID*|0xA0010002 > > + ## This is the lowest supported version number that can be upgraded to, as exposed via the System Firmware descriptor. > + # @Prompt Lowest support version number that can be upgraded to via > + capsule update > + > + gEfiSignedCapsulePkgTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|0 > + x1|UINT32|0xA0010003 > + > [PcdsDynamicEx] > ## This dynamic PCD holds the EDKII system firmware image descriptor. > # This information can be used for version check in EDKII system FMP capsule. > -- > 2.17.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel