From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1434821E62BB5 for ; Fri, 1 Sep 2017 02:29:14 -0700 (PDT) Received: by mail-io0-x22c.google.com with SMTP id f99so13111802ioi.3 for ; Fri, 01 Sep 2017 02:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6DMZSHqoVA4exH21Ujv+qNGjUvLYsFXkHgk1xfXYME4=; b=c323y+BTF6hl9I3p+OCxJesUEQjpe7kdTHw5ZlsbRqXkSj2b2kSCH2l4Xo5jKpWE3H Ag0xaFfU2x3KIewIav0NoTiwMP5ox23uMZSDhDWBst05U8AmAsSAWLdjWwEn/1sLNE9l R9FaNlQGfHba4163UnKHf/gPZ0DAgP98uVcrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6DMZSHqoVA4exH21Ujv+qNGjUvLYsFXkHgk1xfXYME4=; b=K7b1oHm/kpO6Y/v+QlFRY+XThzN6gzfb2KiDhWzI4XfKdAEVHuuxZPmec/XzWuD3ob yes8aqTNMjGLPa68ryntZlan2BCt4DnB1T5MsxUiJXCbgx7I4Ogo0AsZ6e8WyJJmtEqc 2nNNWLXvJHHhYMEl8t5ycmn1iDVL3KXJcFbJpzBIviGDYodR9GEHdIYjYBLOluYv2cdq pHgFwhphd0EuPE7JrlD+GWRSo8hwTB2k7/sdeu9R5BEBKXboz/6TJzZuweBioE0HO9tX TN5IWsoqWo78Nos1ZfzWUlyJD18WxJzD6bqbLRs4dF5ayndPeTBujI5Ee85Y2QxcSEHc pDHQ== X-Gm-Message-State: AHPjjUgnfH3VQKeK7IAqcYaEhidbhyIosalArWZ2UFMLwqtmGSKcpMSl kxuW0sEkQbYlbXjngNbfgRQV5VTpYGo0 X-Google-Smtp-Source: ADKCNb7/V3KHcbytdg1zwXprY9AzMsFVvAOasgWrBEBVdj+UT+y4CPUpdpAnW1gVI9HfwY/utLujFASFsSEAKi+ANCU= X-Received: by 10.107.157.78 with SMTP id g75mr956456ioe.190.1504258317838; Fri, 01 Sep 2017 02:31:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:31:57 -0700 (PDT) In-Reply-To: <1504233451-6455-6-git-send-email-mw@semihalf.com> References: <1504233451-6455-1-git-send-email-mw@semihalf.com> <1504233451-6455-6-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 10:31:57 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , jinghua@marvell.com, Alexander Graf , =?UTF-8?B?SmFuIETEhWJyb8Wb?= Subject: Re: [platforms: PATCH 5/7] Platforms/Marvell: Update ethernet ports types on A70x0 DB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 09:29:14 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 03:37, Marcin Wojtas wrote: > Modify ethernet Port0 and Port1 types to be on par with the board > settings. Initial support required extra extension boards and > converters. This patch sets ports to following settings: > > * Port0 (eth0) -> SFI @ 10Gbps > * Port1 (eth1) -> SGMII over 88E1512 PHY @ 1Gbps > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel > --- > Platform/Marvell/Armada/Armada70x0.dsc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc > index d77e0b6..bbe6ba5 100644 > --- a/Platform/Marvell/Armada/Armada70x0.dsc > +++ b/Platform/Marvell/Armada/Armada70x0.dsc > @@ -101,8 +101,8 @@ > > #ComPhy > gMarvellTokenSpaceGuid.PcdComPhyDevices|{ 0x1 } > - gMarvellTokenSpaceGuid.PcdChip0ComPhyTypes|L"SGMII1;USB3_HOST0;SGMII0;SATA1;USB3_HOST1;PCIE2" > - gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|L"3125;5000;1250;5000;5000;5000" > + gMarvellTokenSpaceGuid.PcdChip0ComPhyTypes|L"SGMII1;USB3_HOST0;SFI;SATA1;USB3_HOST1;PCIE2" > + gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|L"1250;5000;10310;5000;5000;5000" > > #UtmiPhy > gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 > @@ -115,7 +115,7 @@ > gMarvellTokenSpaceGuid.PcdMdioBaseAddress|0xF212A200 > > #PHY > - gMarvellTokenSpaceGuid.PcdPhyConnectionTypes|{ 0x4, 0x4, 0x0 } > + gMarvellTokenSpaceGuid.PcdPhyConnectionTypes|{ 0x8, 0x4, 0x0 } > gMarvellTokenSpaceGuid.PcdPhyDeviceIds|{ 0x0, 0x0 } > gMarvellTokenSpaceGuid.PcdPhyStartupAutoneg|FALSE > > @@ -123,8 +123,8 @@ > gMarvellTokenSpaceGuid.PcdPhySmiAddresses|{ 0xff, 0x0, 0x1 } > gMarvellTokenSpaceGuid.PcdPp2ClockFrequency|333333333 > gMarvellTokenSpaceGuid.PcdPp2GopIndexes|{ 0x0, 0x2, 0x3 } > - gMarvellTokenSpaceGuid.PcdPp2InterfaceAlwaysUp|{ 0x1, 0x1, 0x0 } > - gMarvellTokenSpaceGuid.PcdPp2InterfaceSpeed|{ 0x3, 0x4, 0x3 } > + gMarvellTokenSpaceGuid.PcdPp2InterfaceAlwaysUp|{ 0x0, 0x0, 0x0 } > + gMarvellTokenSpaceGuid.PcdPp2InterfaceSpeed|{ 0x5, 0x3, 0x3 } > gMarvellTokenSpaceGuid.PcdPp2NumPorts|3 > gMarvellTokenSpaceGuid.PcdPp2PortIds|{ 0x0, 0x1, 0x2 } > gMarvellTokenSpaceGuid.PcdPp2SharedAddress|0xf2000000 > -- > 1.8.3.1 >