From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
"Gao, Liming" <liming.gao@intel.com>,
"afish@apple.com" <afish@apple.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers
Date: Sat, 24 Feb 2018 14:10:36 +0000 [thread overview]
Message-ID: <CAKv+Gu-H1QyFC2VT8BXv0384mom5oUNrVG=+uYVgwKntzYAENQ@mail.gmail.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B896B68F@ORSMSX113.amr.corp.intel.com>
On 23 February 2018 at 22:36, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
> Ard,
>
> Just a few comments:
> * Please pre-initialize global mEfiAtRuntime = FALSE;
> * The UNI file in the patch is identical to BaseDebugLibSerialPort.
> Please update UNI file header and strings to describe this as the
> runtime version of the DebugLib as described in the .inf and .C files.
> * gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue should be
> SOMETIMES_CONSUMES in the INF file.
>
> With those changes:
>
> Reviewed-by: Michael D Kinney <Michael.d.kinney@intel.com>
>
Thanks all
Pushed as 8bdb0221152c..ebfca258f5d7
prev parent reply other threads:[~2018-02-24 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 19:56 [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers Ard Biesheuvel
2018-02-22 19:56 ` [PATCH v4 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort Ard Biesheuvel
2018-02-22 19:57 ` [PATCH v4 2/2] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate Ard Biesheuvel
2018-02-23 14:10 ` [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers Ard Biesheuvel
2018-02-23 22:36 ` Kinney, Michael D
2018-02-24 14:10 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-H1QyFC2VT8BXv0384mom5oUNrVG=+uYVgwKntzYAENQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox