From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 04C0B2243692B for ; Sat, 24 Feb 2018 06:04:35 -0800 (PST) Received: by mail-io0-x243.google.com with SMTP id b34so12727730ioj.6 for ; Sat, 24 Feb 2018 06:10:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5w8wOX8iG9mNYmxLNH7i1yBafe3bi0sRUM730EtVgck=; b=BCODyhGuzFsIx/EbR4DO5YxuhXy9r4pcjPy4MVIutXFr3XXjL5K6DJsPGI1O52WtiD sZ6TwezIplwGETv+cgjCPP6WZ4meJoEJ9DLeGXfZc05+rduBX7EW+DwbQTC90j+gS2Om GSfniZ7QXkpMjnoJvsJuYJQWx+aAIc2nO9tuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5w8wOX8iG9mNYmxLNH7i1yBafe3bi0sRUM730EtVgck=; b=Lnz60baV+z1ciRuw2QvBixZnZERT6jwsk4COZE0TORQ7fGU8za+ZuK98plI7EOKUac JDUdk0vM/0UqU1D+ET6vZexf/1EWUKqwhrWNQcta2tgwsZWuGBJkO8Fzl4/G6JA5vOBu 7QTVzj3EB6hBvzCc8dojgyZodmbaOQpCmYTdWTBTRqXrl3Nhp+/QKDsro6/KenAEY74Z RNf8h2gBd/TvDzuqxrs/X3BwloSnH7jHjPOlaGl0Zz6SnDJed0x0mee3T6IVBk9PWMBe 1Jw+Hh0Ac77/7wuceeG42HOUZXZC9rDL6gdl7PheYMOZ/GHGwKkSdesOYUd2Shst9ViY 8p0A== X-Gm-Message-State: APf1xPB58UjDG2G8oKcfXYeZ8S39WbnI+5RefzpYw++fhMzXi9bo1n7m EMuvWyqPeK5NyNllFNAeR52+GoZtiatGQ/T2rMUu1Q== X-Google-Smtp-Source: AG47ELuNzRM7gQ8oAo1y/TP7r8zDeJGR5sSuQFVlFtTkReW9Kjv1+wYJLJp5tIoZkVnUHEAU7rxT4t0dwCGsNn5KwlY= X-Received: by 10.107.56.69 with SMTP id f66mr5513501ioa.170.1519481437851; Sat, 24 Feb 2018 06:10:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Sat, 24 Feb 2018 06:10:36 -0800 (PST) In-Reply-To: References: <20180222195700.7279-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Sat, 24 Feb 2018 14:10:36 +0000 Message-ID: To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Laszlo Ersek , "Gao, Liming" , "afish@apple.com" , "Zeng, Star" , "Ni, Ruiyu" Subject: Re: [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Feb 2018 14:04:36 -0000 Content-Type: text/plain; charset="UTF-8" On 23 February 2018 at 22:36, Kinney, Michael D wrote: > Ard, > > Just a few comments: > * Please pre-initialize global mEfiAtRuntime = FALSE; > * The UNI file in the patch is identical to BaseDebugLibSerialPort. > Please update UNI file header and strings to describe this as the > runtime version of the DebugLib as described in the .inf and .C files. > * gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue should be > SOMETIMES_CONSUMES in the INF file. > > With those changes: > > Reviewed-by: Michael D Kinney > Thanks all Pushed as 8bdb0221152c..ebfca258f5d7