From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D57432118EF74 for ; Thu, 15 Nov 2018 05:09:26 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id m15so29106642itl.4 for ; Thu, 15 Nov 2018 05:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oHJK3VgRm76CWdrx6QF8Vl3Rn8ibVxKE69SZev7vsGI=; b=B9s264GAtux5IVsNNYJtkAVMXro06qQY+xKymvYvRkeIyLZO1NCBuY6JQFIN++QkUh SX7CtEyzv05g0pF4ZWMmXk0b4jotS6idGpniRPa+1Uco2+1Jr9rk05C9pYI36th/oLHS xue93uaDlEzZQLuDJHt96Hd2NaxhJo4MaR5QI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oHJK3VgRm76CWdrx6QF8Vl3Rn8ibVxKE69SZev7vsGI=; b=HWkZSuRMPCMAPkQIpekP+mEYfSJieK/xC26ZzKWbcPkfAfuLzcSpLNB0yc/pMbLkeg R8gilyHDpndcu42/0vTkvOiSpMTqwmbnnoGI1Ru4hSdpwETrLxImZdPcb8g6hR1k9Dk4 gEMIITDBiXeMStF50uKwlvmkMU90Pumyz/kHM9hGU3rM4wkloQh1wBOYhy9wMaz1WhRS 2BDI1RVWinWTVBiCOdsjZiNh0/I6xY340K189RAILpyEuR0okIZnKxFUEOee9VQvgTrJ OA8cmIsN75XBwcQdp8BDx3ZReGwiEydAWo5Q4MV6CZ2xY2KpxDc7WPN/zD+xWBv5GZ1b hSyw== X-Gm-Message-State: AGRZ1gJRAuNrL2E4iY2s0h/+SK+HP+SMUnh8000H7sL8kxYP/IO+Q3os FgIXZZYO6Lzmiq+LUrODzuWfFMsuhvN84MScl97/aA== X-Google-Smtp-Source: AJdET5cBJPW/saWynBJtoyUwX8HX5d12AoJYU/runi/2cAHJSMP3fdWQrEUJ9ZttEx/l9JgUsiDahHLAQp/Ww6gteN8= X-Received: by 2002:a02:8449:: with SMTP id l9-v6mr5669081jah.130.1542287365990; Thu, 15 Nov 2018 05:09:25 -0800 (PST) MIME-Version: 1.0 References: <20181114192724.27068-1-ard.biesheuvel@linaro.org> <20181114200036.o5nv5qnkwlmbkwxu@bivouac.eciton.net> <3b59c20c-c24d-9ca3-be42-0540bec25c3c@redhat.com> In-Reply-To: <3b59c20c-c24d-9ca3-be42-0540bec25c3c@redhat.com> From: Ard Biesheuvel Date: Thu, 15 Nov 2018 05:09:14 -0800 Message-ID: To: Laszlo Ersek Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/ArmGicDxe ARM: fix encoding for GICv3 interrupt acknowledge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 13:09:27 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 15 Nov 2018 at 04:44, Laszlo Ersek wrote: > > On 11/15/18 13:37, Ard Biesheuvel wrote: > > On Wed, 14 Nov 2018 at 14:11, Laszlo Ersek wrote: > >> > >> On 11/14/18 21:00, Leif Lindholm wrote: > >>> On Wed, Nov 14, 2018 at 11:27:24AM -0800, Ard Biesheuvel wrote: > >>>> Fix a typo in the 32-bit ARM version of the GICv3 driver, which uses > >>>> the wrong system register encoding to access ICC_IAR1, and attempted > >>>> to access ICC_IAR0 instead. This results in boot time hangs both > >>>> under QEMU emulation and on real hardware. > >>>> > >>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>> Signed-off-by: Ard Biesheuvel > >>> > >>> Reviewed-by: Leif Lindholm > >>> > >>> I would say given how long we've gone without finding this, > >> > >> Right, that makes me curious -- what has changed now? What exposed this bug? > >> > > > > I was regression testing a EFI workaround I put in the kernel for > > GICv3, which was apparently the first time anyone tried running > > EDK2/ARM on a GICv3 system (which is one of the reasons I wanted to > > get you one of the Socionext SynQuacer boards: it has a GICv3 with > > GICv2 compatibility and support for 32-bit guests, but sadly, we still > > don't have any with fixed silicon) > > > > Thanks! > Laszlo Pushed as 66127011a544b90e800eb3619e84c2f94a354903