public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation
Date: Tue, 9 Oct 2018 09:07:35 +0200	[thread overview]
Message-ID: <CAKv+Gu-H66ktvBiB6PyBP9=1MAaZN60=S7Sz-Xv9ddcpd5C1aw@mail.gmail.com> (raw)
In-Reply-To: <20181009070614.20052-1-liming.gao@intel.com>

On 9 October 2018 at 09:06, Liming Gao <liming.gao@intel.com> wrote:
> GCC 6 or above reports the warning misleading-indentation.
> This patch fixes it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
> index bebe664..e281716 100644
> --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
> +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c
> @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 position)
>          unsigned limit = p->numFastBytes + 1;
>          if (limit > numAvailFull)
>            limit = numAvailFull;
> -        for (len = 3; len < limit && data[len] == data2[len]; len++);
> +        for (len = 3; len < limit && data[len] == data2[len]; len++)
> +        {
> +        }
>
>          {
>            unsigned state2 = kLiteralNextStates[state];

Thanks Liming.

Don't we need this change in all copies of the LZMA SDK?


  reply	other threads:[~2018-10-09  7:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  7:06 [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation Liming Gao
2018-10-09  7:07 ` Ard Biesheuvel [this message]
2018-10-09  7:11   ` Gao, Liming
2018-10-09  7:12     ` Ard Biesheuvel
2018-10-09  8:24       ` Zeng, Star
2018-10-09 10:13         ` Laszlo Ersek
2018-10-09 10:24           ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu-H66ktvBiB6PyBP9=1MAaZN60=S7Sz-Xv9ddcpd5C1aw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox