From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B76D21130058 for ; Tue, 9 Oct 2018 00:07:37 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id t7-v6so362902ioj.13 for ; Tue, 09 Oct 2018 00:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xjryqyjvEQbwl1LxGdV4Id3K1T+Ygunp4h1e+zl2zks=; b=jUw21YbePSlzT+/cuJz7F/P8D/4QbC++WDHoOwnOJF4nIZxfN0+IHM77Ehegn8pCJT vYy/Dm1GdHMO+VX+/y5zXD62Tkd2CEYZ3R27hNAlqkKyeVLk6UY457YAKfAZIe+YeQsd TGJDxIAZ88AwXnhlHPAuezkEb2pi/SwbC1iX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xjryqyjvEQbwl1LxGdV4Id3K1T+Ygunp4h1e+zl2zks=; b=FS7gucb+sNHgorO+8Z+XN0jZ0wAy8P2SaN3b7+MCCINd97RIyUlkXWLg290zmS6lOO s4mGcn+O2Ts/HMRayUiliybEQi2HLilEF9FHobFC10l/JMK3U9r1uE2I5JOu27wZ3e4V 2Q67aHisBfHTj1AypPCglkPs6H3rZ4no9Ryqaj6zABFQ7KDeyseIJhK+83ZhghY+429K fTAUiUgOU+qehoDkzd6JvSN8uY8HwbyF8qJzD+2jSORVoC4EEkTTReJZdMb+oCcjjJq/ vZ4ZVleDs12N/wVXruv6XeuQ3X2lz9gtyVSV4Sh7lh0Pi/eZ3xC+drhyyoRmWlRGM7dj YC8g== X-Gm-Message-State: ABuFfog/8bSJMkmy11rwCVN8SlHlaSJFLnYVKlnqnmp4xg4hobgnf1w4 20hCVtIjm83jo0m8knjcpnhxr6kuU2Snn0yClE1qJIxb X-Google-Smtp-Source: ACcGV63BICLJAAT+jZN74TLT5cMfqyVweR6zhl7P8PKX0dhR8EbADTWAuF/kAQjB1liSbgvxoY+pFf+GCqRcJSlukTg= X-Received: by 2002:a6b:5d12:: with SMTP id r18-v6mr17806803iob.170.1539068856280; Tue, 09 Oct 2018 00:07:36 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Tue, 9 Oct 2018 00:07:35 -0700 (PDT) In-Reply-To: <20181009070614.20052-1-liming.gao@intel.com> References: <20181009070614.20052-1-liming.gao@intel.com> From: Ard Biesheuvel Date: Tue, 9 Oct 2018 09:07:35 +0200 Message-ID: To: Liming Gao Cc: "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 07:07:37 -0000 Content-Type: text/plain; charset="UTF-8" On 9 October 2018 at 09:06, Liming Gao wrote: > GCC 6 or above reports the warning misleading-indentation. > This patch fixes it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > --- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > index bebe664..e281716 100644 > --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c > @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 position) > unsigned limit = p->numFastBytes + 1; > if (limit > numAvailFull) > limit = numAvailFull; > - for (len = 3; len < limit && data[len] == data2[len]; len++); > + for (len = 3; len < limit && data[len] == data2[len]; len++) > + { > + } > > { > unsigned state2 = kLiteralNextStates[state]; Thanks Liming. Don't we need this change in all copies of the LZMA SDK?