From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 81A5A1A1E91 for ; Tue, 11 Oct 2016 09:28:11 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id r30so30493268ioi.1 for ; Tue, 11 Oct 2016 09:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MNM1XIRGDj+2qEDzz7fbNpFAzoVC7U+WHajF4A7nytw=; b=UsCde/LvR/wwSChXalxIllVD7J8JTqOzHJyxjd1YPARl9p4J2Dicl3IXg0Fb9Vsl6A Mc7SOtNAD8/ADmdxD3lAKDpWvdqyRr+gVIwGwS5Y6kFuRObei23m68wKJIcF1gFHBRvV xFG0b/FKwmMGC4k7q24SxPuaxtUAjEpFGNB28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MNM1XIRGDj+2qEDzz7fbNpFAzoVC7U+WHajF4A7nytw=; b=JDs+VnwupNiTC3dRxguP9BJiZjUMhKl+4wdyGDO966dXf6+9WevHgPzBf7aLq7jew/ PD4GjSakym1CMC+lRLVAobegw+EoU9hlgz8p/ljBivHyGG5DjlRr13ufoC1M2ow0sb97 ga3RjB+ebVrrKGLa+mkC8U3iSvecsIRgOhlG/e54/dEbiul2axckBbRw5rqRrpsW5rJ/ 17JPnthGszAJOYXIRx2KagiVcXDY4wiljF+9DUJYujKoNhjLs5TsvUCDeN9nQu1PGENa jWcZERjSOahIEUoexBDN2Ce+uv22GaENPCth3h6pu5NdJIZ4f7HLRDpe+yY+J3arGGpV P7KA== X-Gm-Message-State: AA6/9RkkGn0qSvY+PJ9fTHRINxS2uJym+FNXQS7np3IxaPtRJSMPAGSuFQyJ9Ai7TCFhG8lgLgqCs1ZXtXrz/Ic9 X-Received: by 10.107.34.197 with SMTP id i188mr6843376ioi.138.1476203290798; Tue, 11 Oct 2016 09:28:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Tue, 11 Oct 2016 09:28:10 -0700 (PDT) In-Reply-To: References: <1474470147-23156-1-git-send-email-haojian.zhuang@linaro.org> From: Ard Biesheuvel Date: Tue, 11 Oct 2016 17:28:10 +0100 Message-ID: To: Ryan Harkin Cc: Haojian Zhuang , edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v3 00/10] enhance mmc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 16:28:11 -0000 Content-Type: text/plain; charset=UTF-8 On 11 October 2016 at 17:27, Ryan Harkin wrote: > On 11 October 2016 at 17:24, Ard Biesheuvel wrote: >> Hi Ryan, >> >> On 11 October 2016 at 17:22, Ryan Harkin wrote: >> [...] >>> And OpenPlatformPkg was taken from my repo, which only carries one >>> patch essential for TC2 booting: >>> c22a665 2016-01-29 HACK: Platforms/ARM: TC2: set >>> gArmTokenSpaceGuid.PcdNormalMemoryNonshareableOverride TRUE [Ryan >>> Harkin] >> >> Shouldn't we simply merge that patch? > > I think Leif said no, back when TC2 broken in mainline. > > The commit that broke it was 0c9a522f28772049ae37c85b8ae589a98d2d3b81 > "ArmPkg/ArmLib: mark all cached mappings as (inner) shareable". IIRC > Leif said there is something wrong with the TC2 setup code meaning > that we need to set the PCD, even though we shouldn't need to. > > And I've never had time to work it out, so I've just carried the patch. Ah right, I remember now.