From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::541; helo=mail-ed1-x541.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B2761211A459B for ; Thu, 20 Dec 2018 03:42:16 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id d39so1427193edb.12 for ; Thu, 20 Dec 2018 03:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E4wVYOyiB74KhUKhZazTw4mngKoVJTNFK+hleHsj56w=; b=CMLHkCHUawpc24GCLcd5Oj2Nx/ODBrvgU1efs7REQ8JIRNlueDHtgV/3cqn8FgQ/dk H8jvarwJdXR4sm4dxIoGvB1CSM4UWmrDMAD1Ct3rf6DK9fGz9TCeeuWcEu4DTg/2jzOO jsKj3bfzcuP99hGbuYPaiXTLXaC5n5eOeTiQE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E4wVYOyiB74KhUKhZazTw4mngKoVJTNFK+hleHsj56w=; b=iljzF2Fi4EAyOgQWAzTwSYCF3jmUsaCg4cLXmAOSRUi2xRQuI2m+wQ6Etlpq17VuKp GkMQZB1tver206d2FhsqezqOtcz6vE3fTJ5zdxrPk84bZ6hIpVWRWKvjuHvLw+L9R7Ow M7WRR9gDi2SS9SkWrjWV5+iGvq0JNXGXGPklxIjSOvcmAVtqKO+6wmac3E5t7Ko7DPhD v5JmrGmoD9vBuO0iHvI4UQCtLMECaIuFFcom4KxSs8DIl+Zzx8+dUj/w0JHMmhA50oCh /UmJgsa5LogXlB4XJL/UB4Xqmu0Jn1LjMIW/m0TQgelKZTaRIEGtyQVUSWlol8zxWe08 Jjdg== X-Gm-Message-State: AA+aEWarOw5mkoV6YlH41z06R4jWLAr5zbhLVDvHJwcPdA8OZ/OhZ5Of g91MjoIbmxYuBu0V06pX/15MdiTON/43o84Yb/xJYgROyk8= X-Google-Smtp-Source: AFSGD/Vq2VsemuVNP8c77+h/X/UFp3hSPChPkTY8O0mmeEcdOkEE94TuQI/ytdA2m3UqOsSnIopgnPVdlt1jt4wRgC0= X-Received: by 2002:aa7:d487:: with SMTP id b7mr22384008edr.256.1545306134556; Thu, 20 Dec 2018 03:42:14 -0800 (PST) MIME-Version: 1.0 References: <20181219204023.6317-1-ard.biesheuvel@linaro.org> In-Reply-To: <20181219204023.6317-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 20 Dec 2018 12:42:03 +0100 Message-ID: To: "edk2-devel@lists.01.org" Subject: Re: [PATCH v2 0/4] ArmPkg, ArmPlatformPkg: watchdog driver cleanup X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 11:42:17 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 19 Dec 2018 at 21:40, Ard Biesheuvel wrote: > > This series cleans up the code of the two watchdog drivers we have for > ARM systems, and brings them in compliance with the PI spec, which > specifies that the default action of the watchdog can be overridden > by registering a handler. > > Note that the TC2 code in edk2-platforms will have to be brought up to > date. The SP805 on the FVP model seems terminally broken (it is 'wired' > to the 24 MHz APB clock instead of the 32 kHz WDOG clock, so I'll switch > that one over to use the SBSA watchdog instead) > > Changes since v1: > - always fall back to calling gRT_>ResetSystem() if the registered handler > returns > - WARN() if running the SP805 driver with interrupt handling disabled > - add some R-bs > > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Thomas Panakamattam Abraham > Cc: Meenakshi Aggarwal > Cc: Udit Kumar > Cc: Matteo Carlini > Cc: Nariman Poushin > > Ard Biesheuvel (4): > ArmPlatformPkg/SP805WatchdogDxe: cosmetic cleanup > ArmPlatformPkg/SP805WatchdogDxe: switch to interrupt mode > ArmPkg/GenericWatchdogDxe: clean up the code > ArmPkg/GenericWatchdogDxe: implement RegisterHandler() method > Pushed as 87b920fe22be..ba808d11f6a3 Thanks all