public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: add missing newline
Date: Mon, 11 Dec 2017 18:06:13 +0000	[thread overview]
Message-ID: <CAKv+Gu-J61RetpR57PhZn_+1AzakzNpokQ6EmnGqoO6XZZTPdw@mail.gmail.com> (raw)
In-Reply-To: <20171211114802.43vrwz7kqtxnavxz@bivouac.eciton.net>

On 11 December 2017 at 11:48, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Sat, Dec 09, 2017 at 09:56:24AM +0000, Ard Biesheuvel wrote:
>> Add a missing newline to the version string output that is displayed
>> on the serial console, or the next line will be appended to it.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as 26b99f3bb3f1fc34962e203ba431447dcd2ad946

>> ---
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> index ccdb3e0a5d78..61ab61ccc780 100644
>> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole (
>>    Status = BootLogoEnableLogo ();
>>    if (EFI_ERROR (Status)) {
>>      if (FirmwareVerLength > 0) {
>> -      Print (VERSION_STRING_PREFIX L"%s",
>> +      Print (VERSION_STRING_PREFIX L"%s\n",
>>          PcdGetPtr (PcdFirmwareVersionString));
>>      }
>>      Print (L"Press ESCAPE for boot options ");
>> --
>> 2.11.0
>>


      reply	other threads:[~2017-12-11 18:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-09  9:56 [PATCH] ArmPkg/PlatformBootManagerLib: add missing newline Ard Biesheuvel
2017-12-11 11:48 ` Leif Lindholm
2017-12-11 18:06   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-J61RetpR57PhZn_+1AzakzNpokQ6EmnGqoO6XZZTPdw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox