From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BD4802214E323 for ; Mon, 11 Dec 2017 10:01:36 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id z6so18023674iti.4 for ; Mon, 11 Dec 2017 10:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uOV0P6X26jX0ZwTN+T1TfNLEpragMO/snFnQUYUyxQY=; b=aNqrxZzqZ7WuEb0iRiKTE7vyAGwcoyD/UJHx2dO07dixIWvKbLJW/MflQunlqDC5ec Lfge1yNPefZ+eeduIK3Lykia/UrjSa4bXTNUFaRk25NlcKSi4TzPvK9N4EkTtbNrEPzw JwVfWv+/vR7Ta9/jgBz1BXpUou9fIshFYKONE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uOV0P6X26jX0ZwTN+T1TfNLEpragMO/snFnQUYUyxQY=; b=DMYPUUaagJ/Hl2SyfznhBaIhnjN9aaCtRAHrukVrsuc4V6PHeHbL8lCN+zaa7cQHIb hrIRwah/gafvWKPEg+M+EhV3EpPas8YFBAUU7oNSkS9VHv2gbMDbtTgeCJYJHQ/Fq5NW vKwui2QSl0RiDiz9RiYgzgLbAvVDBWdT664Vuy3rVdBBx/5WSuAQ8tBqgT3Fj+KPrYr0 1TQ97OmarJdUnrD38CtWcrJkSLZtQm9WFC/aVpybF4PwHe7wqcg7rXYih8aU123XsgVc TvdiM02IfoLlp0AZ8f+wi0E4zrdDreQXP0sNvuNYWuyE94RTIxTohG8Dif111+oQmT/7 OQRg== X-Gm-Message-State: AKGB3mKIh8uUkO3v6xv20rbmBmLbCL98AbQU1TdV1aKjFeiXuwDT0xnV bPB6XCaSNbgPyzXaci2U7ujXnisk7bK6DpayIFxO8VmIuKM= X-Google-Smtp-Source: ACJfBot7WKYj6YPX2PGKpqC4xLJKKFIE/7AVUTLgtFUNzoPgBLPzfx1uq+d9Qw6Lf4ZxNQzMh8Hd/bwzvZK3cHyIcmw= X-Received: by 10.107.151.142 with SMTP id z136mr1641949iod.248.1513015573842; Mon, 11 Dec 2017 10:06:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 11 Dec 2017 10:06:13 -0800 (PST) In-Reply-To: <20171211114802.43vrwz7kqtxnavxz@bivouac.eciton.net> References: <20171209095624.20915-1-ard.biesheuvel@linaro.org> <20171211114802.43vrwz7kqtxnavxz@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 11 Dec 2017 18:06:13 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: add missing newline X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 18:01:36 -0000 Content-Type: text/plain; charset="UTF-8" On 11 December 2017 at 11:48, Leif Lindholm wrote: > On Sat, Dec 09, 2017 at 09:56:24AM +0000, Ard Biesheuvel wrote: >> Add a missing newline to the version string output that is displayed >> on the serial console, or the next line will be appended to it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks. Pushed as 26b99f3bb3f1fc34962e203ba431447dcd2ad946 >> --- >> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index ccdb3e0a5d78..61ab61ccc780 100644 >> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -549,7 +549,7 @@ PlatformBootManagerAfterConsole ( >> Status = BootLogoEnableLogo (); >> if (EFI_ERROR (Status)) { >> if (FirmwareVerLength > 0) { >> - Print (VERSION_STRING_PREFIX L"%s", >> + Print (VERSION_STRING_PREFIX L"%s\n", >> PcdGetPtr (PcdFirmwareVersionString)); >> } >> Print (L"Press ESCAPE for boot options "); >> -- >> 2.11.0 >>