public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Date: Tue, 24 Jul 2018 15:22:16 +0200	[thread overview]
Message-ID: <CAKv+Gu-JQMHBh3Ly79=qMk8-uz0zsOH1ogFBKfpJ=Ra_+tNJeQ@mail.gmail.com> (raw)
In-Reply-To: <20180724132114.31505-1-lersek@redhat.com>

On 24 July 2018 at 15:21, Laszlo Ersek <lersek@redhat.com> wrote:
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Notes:
>     built on all six platforms:
>
>     ArmVirtQemu-AARCH64
>     ArmVirtQemu-ARM
>     ArmVirtQemuKernel-AARCH64
>     ArmVirtQemuKernel-ARM
>     ArmVirtXen-AARCH64
>     ArmVirtXen-ARM
>
>  ArmVirtPkg/ArmVirt.dsc.inc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
>    PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
>    OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
>    PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> -  PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
>    UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
>    ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
>
> --
> 2.14.1.3.gb7cf6e02401b
>


  reply	other threads:[~2018-07-24 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 13:21 [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Laszlo Ersek
2018-07-24 13:22 ` Ard Biesheuvel [this message]
2018-07-24 20:46   ` Laszlo Ersek
2018-07-24 22:25 ` Carsey, Jaben
2018-07-25  0:44   ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu-JQMHBh3Ly79=qMk8-uz0zsOH1ogFBKfpJ=Ra_+tNJeQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox