* [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
@ 2018-07-24 13:21 Laszlo Ersek
2018-07-24 13:22 ` Ard Biesheuvel
2018-07-24 22:25 ` Carsey, Jaben
0 siblings, 2 replies; 5+ messages in thread
From: Laszlo Ersek @ 2018-07-24 13:21 UTC (permalink / raw)
To: edk2-devel-01
The class name for the "PeiResourcePublicationLib" instance is just
"ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
module included in the ArmVirtPkg platforms depends on this lib class;
remove its resolution.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Notes:
built on all six platforms:
ArmVirtQemu-AARCH64
ArmVirtQemu-ARM
ArmVirtQemuKernel-AARCH64
ArmVirtQemuKernel-ARM
ArmVirtXen-AARCH64
ArmVirtXen-ARM
ArmVirtPkg/ArmVirt.dsc.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 8bb54c5e6579..70a0ac4d786c 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
- PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
--
2.14.1.3.gb7cf6e02401b
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
2018-07-24 13:21 [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Laszlo Ersek
@ 2018-07-24 13:22 ` Ard Biesheuvel
2018-07-24 20:46 ` Laszlo Ersek
2018-07-24 22:25 ` Carsey, Jaben
1 sibling, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2018-07-24 13:22 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: edk2-devel-01, Julien Grall
On 24 July 2018 at 15:21, Laszlo Ersek <lersek@redhat.com> wrote:
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>
> Notes:
> built on all six platforms:
>
> ArmVirtQemu-AARCH64
> ArmVirtQemu-ARM
> ArmVirtQemuKernel-AARCH64
> ArmVirtQemuKernel-ARM
> ArmVirtXen-AARCH64
> ArmVirtXen-ARM
>
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
>
> --
> 2.14.1.3.gb7cf6e02401b
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
2018-07-24 13:22 ` Ard Biesheuvel
@ 2018-07-24 20:46 ` Laszlo Ersek
0 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2018-07-24 20:46 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel-01
On 07/24/18 15:22, Ard Biesheuvel wrote:
> On 24 July 2018 at 15:21, Laszlo Ersek <lersek@redhat.com> wrote:
>> The class name for the "PeiResourcePublicationLib" instance is just
>> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
>> module included in the ArmVirtPkg platforms depends on this lib class;
>> remove its resolution.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Julien Grall <julien.grall@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Commit 49a4797e9c68, thanks!
Laszlo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
2018-07-24 13:21 [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Laszlo Ersek
2018-07-24 13:22 ` Ard Biesheuvel
@ 2018-07-24 22:25 ` Carsey, Jaben
2018-07-25 0:44 ` Gao, Liming
1 sibling, 1 reply; 5+ messages in thread
From: Carsey, Jaben @ 2018-07-24 22:25 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01
Laszlo,
Do you think that using the incorrect name for a library instance should generate an error? I would have thought it would have...
-Jaben
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 24, 2018 6:21 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous
> ResourcePublicationLib resolution
>
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> built on all six platforms:
>
> ArmVirtQemu-AARCH64
> ArmVirtQemu-ARM
> ArmVirtQemuKernel-AARCH64
> ArmVirtQemuKernel-ARM
> ArmVirtXen-AARCH64
> ArmVirtXen-ARM
>
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
>
> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc
> eLib.inf
>
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> ull/OemHookStatusCodeLibNull.inf
>
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> -
> PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR
> esourcePublicationLib.inf
>
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
>
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx
> tractGuidedSectionLib.inf
>
> --
> 2.14.1.3.gb7cf6e02401b
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
2018-07-24 22:25 ` Carsey, Jaben
@ 2018-07-25 0:44 ` Gao, Liming
0 siblings, 0 replies; 5+ messages in thread
From: Gao, Liming @ 2018-07-25 0:44 UTC (permalink / raw)
To: Carsey, Jaben, Laszlo Ersek, edk2-devel-01
Jaben:
Yes. BaseTools can generate the error message for it. But, more checker in BaseTools parser phase will also increase the build performance. This is the balance here.
Thanks
Liming
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Carsey, Jaben
> Sent: Wednesday, July 25, 2018 6:25 AM
> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
>
> Laszlo,
>
> Do you think that using the incorrect name for a library instance should generate an error? I would have thought it would have...
>
> -Jaben
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Laszlo Ersek
> > Sent: Tuesday, July 24, 2018 6:21 AM
> > To: edk2-devel-01 <edk2-devel@lists.01.org>
> > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous
> > ResourcePublicationLib resolution
> >
> > The class name for the "PeiResourcePublicationLib" instance is just
> > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> > module included in the ArmVirtPkg platforms depends on this lib class;
> > remove its resolution.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Julien Grall <julien.grall@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >
> > Notes:
> > built on all six platforms:
> >
> > ArmVirtQemu-AARCH64
> > ArmVirtQemu-ARM
> > ArmVirtQemuKernel-AARCH64
> > ArmVirtQemuKernel-ARM
> > ArmVirtXen-AARCH64
> > ArmVirtXen-ARM
> >
> > ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> > index 8bb54c5e6579..70a0ac4d786c 100644
> > --- a/ArmVirtPkg/ArmVirt.dsc.inc
> > +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
> >
> > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc
> > eLib.inf
> >
> > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> > ull/OemHookStatusCodeLibNull.inf
> >
> > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> > PeCoffGetEntryPointLib.inf
> > -
> > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR
> > esourcePublicationLib.inf
> >
> > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> > mpressLib.inf
> >
> > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx
> > tractGuidedSectionLib.inf
> >
> > --
> > 2.14.1.3.gb7cf6e02401b
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-25 0:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 13:21 [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Laszlo Ersek
2018-07-24 13:22 ` Ard Biesheuvel
2018-07-24 20:46 ` Laszlo Ersek
2018-07-24 22:25 ` Carsey, Jaben
2018-07-25 0:44 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox