From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22c; helo=mail-it0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 354AD20954BAD for ; Thu, 15 Mar 2018 00:23:51 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id w63-v6so7844137ita.3 for ; Thu, 15 Mar 2018 00:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=H0+NTFURedWcRNYAn5M+eu3AFdCMYRXN7DLhqU/t5ZY=; b=Yhand4Ob6dDCZmObIwB8okMmeBdsHWS8C9g0wTGuz7mk6unt5YdYGZ94vMdFZLV6uo jk7GVLadoFUgt3EtyhreDPPZbAj7nkwL4eYERuY0ed/R1PQE2J6T0GHK5l8xHwGt5/2u exzriJ299RC8EqhRCOCnnbc97ft6nBEcNelmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=H0+NTFURedWcRNYAn5M+eu3AFdCMYRXN7DLhqU/t5ZY=; b=gI4bVlcK3Hmy+HgneIsoqeyaFwgPls9udRz9DMY7O3ZJYPUedqAZ61uMKpaspTXDx5 uK51FKrYf4huh8HQQv8UhBMRbIoCagfMSOTjjaNh4114e0yToDUehXQkrhWn6A/fRTJF MORy8OQwPns+sz1nYqVKuzenhEz+sMQquDR19tlxWPU1igmh2CcBR64AviUoI770Hc8w TOdatRG9FTkkr5sTVb6gFfg3EB/hpCRlZM5M3C1PUOsnLm/pO7o/eY7PxOsRxGtQOhoM 1k/NPPQlK5yaWTZgawMC6Avifo7EGM91Mp2KoVQfm9uBVyjEQoROGAMwqvyv2//xLO2o latA== X-Gm-Message-State: AElRT7E4hhYlceMraLDJYJYYYkrSPsJr2nOBrpeNRkgIRLaC+niGplXy RS/uQaWrLWPh+S5+TSP+9n1W7hIAfxjcY9ZzoDJqCg== X-Google-Smtp-Source: AG47ELui2UlpiK6/OBJbSFAdq2lxW4SvAPOHddtsBjJgMJnRRsru73Sx7+u7mR8R6hHItSmdXPTf/uKx6umkV34BzYI= X-Received: by 10.36.135.73 with SMTP id f70mr752414ite.50.1521099014985; Thu, 15 Mar 2018 00:30:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Thu, 15 Mar 2018 00:30:14 -0700 (PDT) In-Reply-To: <20180315071133.GD108227@SZX1000114654> References: <1520901090-96694-1-git-send-email-heyi.guo@linaro.org> <1520901090-96694-2-git-send-email-heyi.guo@linaro.org> <0403f2bf-d6a8-b101-73a2-949946f71e46@arm.com> <20180314002509.GE96299@SZX1000114654> <86a7vbaynt.wl-marc.zyngier@arm.com> <20180315071133.GD108227@SZX1000114654> From: Ard Biesheuvel Date: Thu, 15 Mar 2018 07:30:14 +0000 Message-ID: To: Guo Heyi Cc: Marc Zyngier , "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm Subject: Re: [PATCH v2 1/1] ArmPkg/TimerDxe: Add ISB for timer compare value reload X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 07:23:52 -0000 Content-Type: text/plain; charset="UTF-8" On 15 March 2018 at 07:11, Guo Heyi wrote: > Hi Marc and Ard, > > I found the timer re-enable code was added by Ard for special reason: > > commit b1a633434ddc5fc28de817debd963f7845fb78c7 > Author: Ard Biesheuvel > Date: Thu Sep 18 21:16:47 2014 +0000 > > ArmPkg/TimerDxe: add workaround for KVM timer interrupt handling > > So this line of code cannot be removed and I will add an ISB after enabling > timer. > I'm not sure. IIUC, the KVM issue that required this has been fixed long ago, and I don't want to carry this forever. Marc? > Another strange thing is that we got lots of "Spurious GIC interrupt" error > messages when timer enable code was removed, though at last it could boot to EFI > shell. Please let me know if you have any idea about the possible reason of this > issue. > No idea, sorry.