From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1B062211A759E for ; Wed, 16 Jan 2019 12:38:07 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id p197so4672670itp.0 for ; Wed, 16 Jan 2019 12:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X0Z6EevEObDPB9yS4rO01h/cjeq/X7eSdGzNu0WYCik=; b=g0cUIvuujb8Z3xryvhP+gwxFpQHl2+n3tIgqJ02KJjCXYYkuByzH5uSRItFilwTOny JiUpSnVDzrI1bn/06dBHW0/+wxtfDJg37O9fVsDJE0R/kDHpZtej4+WSfR/wbY5C/GHv 28hob0MnaoMsTniCu9G9T0LbBRi/A9dYsW4bI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X0Z6EevEObDPB9yS4rO01h/cjeq/X7eSdGzNu0WYCik=; b=hbFpgS4w0JTMBr3A1QDVIehU/X1sG1dNAZXvC+IVNBZmDmgwSaWlo/MQr1ZGaQtRE8 RXBW/JPP2YbNn8CoBKO28hKu7HTLWncoy32R+7HX+t0YDiXP3sXT/Em1pjq4mn3ew/f6 oU7KLHVRFtYlDk966wYcTQVK/lhxxI2B76mKjupiJEMXw+MoGKIm4xY0iYUAApejLfzP 0ZC2da8I05cDG2stvo1t5zrcrl8LXpc59qetyhTytuo0ftq1PAMpMYJ654D+x4u1UAaL dImBQxZb1h/voOvyK6n+8L19U9PAri3XGW7jH4UZ9eqSPeCxR7Fac5Pph3eNaUjJ4KEp 4SLA== X-Gm-Message-State: AJcUukfB8NKtdD00/YwOVqFOKMlWUYazkOwOpUTcLeB3tpZ97/qleEMV 200bj/CAoR359Wn5g9JwOcAcstkcHrt4UgfdnIPFhwEY8mI5WQ== X-Google-Smtp-Source: ALg8bN66CFKQpNe77YzU4AaWO+FTorveUJ+HMp4pCdILATMGagLdfbIRbAONpUWqFyL5WaOkJ0NGw0WyGwC/XjwipYk= X-Received: by 2002:a02:4c9:: with SMTP id 192mr6234292jab.2.1547671086313; Wed, 16 Jan 2019 12:38:06 -0800 (PST) MIME-Version: 1.0 References: <20190102130044.32453-1-ard.biesheuvel@linaro.org> <20190116201757.6563lz5jb76m3nqg@bivouac.eciton.net> In-Reply-To: <20190116201757.6563lz5jb76m3nqg@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 16 Jan 2019 21:37:55 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] EmbeddedPkg/NorFlashInfoLib: convert to BASE library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 20:38:07 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 16 Jan 2019 at 21:18, Leif Lindholm wrote: > > On Wed, Jan 02, 2019 at 02:00:44PM +0100, Ard Biesheuvel wrote: > > The library's MODULE_TYPE and the module type restrictions it > > defines are needlessly strict. Just change the library to BASE > > type and drop the restrictions entirely. Also, drop a bogus > > library dependency on DxeServicesLib. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as 31f5388006fc..66cffa652512 > > --- > > EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > index b4b33247fa52..ee207ae7e9d7 100644 > > --- a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > +++ b/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf > > @@ -16,9 +16,9 @@ [Defines] > > INF_VERSION = 0x00010019 > > BASE_NAME = NorFlashInfoLib > > FILE_GUID = 6b639c7e-9b53-4e9f-89a3-2e711729709c > > - MODULE_TYPE = DXE_DRIVER > > + MODULE_TYPE = BASE > > VERSION_STRING = 1.0 > > - LIBRARY_CLASS = NorFlashInfoLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION > > + LIBRARY_CLASS = NorFlashInfoLib > > > > [Sources] > > NorFlashInfoLib.c > > @@ -30,5 +30,4 @@ [Packages] > > [LibraryClasses] > > BaseLib > > DebugLib > > - DxeServicesLib > > MemoryAllocationLib > > -- > > 2.19.2 > >