From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22a; helo=mail-it0-x22a.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E841221193083 for ; Wed, 20 Jun 2018 11:03:59 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id p185-v6so895757itp.4 for ; Wed, 20 Jun 2018 11:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pzP9+cMtqN0+RIuU7jxTFz+it1ks4hZ+zSs6x0oyj2M=; b=JrHHiHsiOemC1BYxFF/DPy2coHSEM6WuqJ8twPFQHRl9xjiDrR7IxLaQ70oFQn8P6o poXxlV6BxVRAO01g9mcNsXEnr7r0diopROrOLv0L0jeaagJ0UntRDVoxXNU236Mhh2y4 8YeiDna7szCteFgGaVNQPqrjk2zIrXSH/HGKc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pzP9+cMtqN0+RIuU7jxTFz+it1ks4hZ+zSs6x0oyj2M=; b=MX2ZJAAzcsHdax7aFg7V4rAI1d/Xr9WtKBjkprPqSwp3b1i2+p0AxNfzxfyFgfwnBX +3ET1ivDh/wVj6c4UsMrXNZ9EJDd9RXbcO4oYoWAS6abSB8fp8RgjAyrTOzx9qjF0t+K vfDpY9iXfrGotGlGZJrNLuk608gI0pTR6TY/DAGIejwoQkOMDLXIt8a2WuMAZmM3Vnac 3GtNInngf62oZ9dl635vy4zcKFwsNJ1D4mXJaZnwc895J3qrcb6H92906dwiOh5ngSVa w2vUhnJFetC0EIyztk/J0eZX7cbuOnsHN3Vf5aElUB+Z8aDVApBnvbqeX+eiXKI8fjnO 961A== X-Gm-Message-State: APt69E3Mzr+73RoXv5Yo5mJm9e7ekYpiOPPKKiu3MZrRysBbpUPHI5PT zvlHbk1JSXMjjo97bodcMIfQwhgGTSfQPLngpCz02w== X-Google-Smtp-Source: ADUXVKKZTD+1/3MlIAnd4gy4NW99+JRMQyOe/jhFbCEKc1RWeoMLCMACK7QqZpHLqymwNPX/Arxt/4/LAvM5R17dO9s= X-Received: by 2002:a24:e105:: with SMTP id n5-v6mr2459809ith.68.1529517839057; Wed, 20 Jun 2018 11:03:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Wed, 20 Jun 2018 11:03:58 -0700 (PDT) In-Reply-To: References: From: Ard Biesheuvel Date: Wed, 20 Jun 2018 20:03:58 +0200 Message-ID: To: Evan Lloyd Cc: Leif Lindholm , nd , "edk2-devel@lists.01.org" , Stephanie Hughes-Fitt , Matteo Carlini Subject: Re: Query about variable initialization X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 18:04:00 -0000 Content-Type: text/plain; charset="UTF-8" On 20 June 2018 at 19:48, Evan Lloyd wrote: > Hi Ard, Leif. > I've noticed a number of comments like Ard's recent "We don't permit initialized automatic variables.", > and similar changes have been made to Sami's AcpiView. Note: I'm not objecting to doing it the way maintainers prefer, which is why this is not a response. > > My understanding was that the CCS was changed some time back to remove the restriction on initializing variables (and I further think I remember Leif being a prime mover in that). I don't remember, to be honest. But I think it is a stupid rule, and so if we haven't already, I hope we can get rid of it. IIRC, this limitation had something to do with a particularly nice exhibit in the Tianocore toolchain museum that generated bigger binaries for initialized automatic variables (as compared to assignments performed separately). But let's not get into the toolchain situation, shall we? > If that is the case, I suspect the real problem is with ECC.py, which still whinges about it, so probably needs fixing. > Can you confirm that I haven't got a firm grasp on the wrong end of the stick, please? > I could not find the limitation in the current version of the CCS, and so whether it was there at /some/ point doesn't seem relevant to me. We could file a bugzilla, and/or propose a patch that removes this part from ECC.py (although I am not touching the python code if I can avoid it)