From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 14AC221A00AE6 for ; Sat, 13 Oct 2018 10:17:09 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id m16-v6so11447697ioj.4 for ; Sat, 13 Oct 2018 10:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=R1idxp8ER4l+SVRz/KU8zNJ5SOuIL7DWQRz6MuEwtik=; b=c08t6Wq0FmbtcRym53ZFPkErWwIXrzUtLcg0VcBSiLfHo0dEHzHYRc0es4O2xCwwdT IBEfWfhhvGTGeS33zlXZz63s7V0Acnpu71NyaOqfIRhQvMgWUJrT9zrxEJXeAMpFx0ZO oW2Zoc7WvTUFZXGgPL6lVCU2hGGLubV8H5oVc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=R1idxp8ER4l+SVRz/KU8zNJ5SOuIL7DWQRz6MuEwtik=; b=FY7vGlq8gqMyaOqmfrHFxOwmp/cU52EeFWbw0UPHyzfFgv4pF6QyX/3eT7UEl8Qy2D ZmjYabFxHuXOwuu+OjKlH0gKizmvR8XR2gA9ZTqCZITqCRktmVkGHez30ky9BVudp0Be Pez6yw3Jip9de5cZoyGIJHAs94COsl5UrBJSJi5nfmMvEOhs7NlvLI65CPYdfcQ/tu1e gbY/qRkitAbsOrwlFX4lDgALQN/8icQohmbwzS1G77+yX3vReWqjj8LbncTP7TCUgnDD cGhwij/bEuomGTue+UwxsO3H7goTK5JQgTLi22ixdJdJvaGJqhkm437ElKYNRTE64gqF 9Ilw== X-Gm-Message-State: ABuFfoiQWu3Xd4d6WPQIOUFZdKDqma210Q2GGmuCQEUhpYx1VgQoqaXX HVeYT6vPK31UTyH6o8p2GPTpfkhialfKUmWlAbbKtw== X-Google-Smtp-Source: ACcGV63zKf+GhjzDo3jP9tq1hhZe8OF37AZYNFZQ6hcii+S1W85JbB4PxLY0dVPf9FyCVsbbYm8+gmmMzynSUIe6oVI= X-Received: by 2002:a6b:be83:: with SMTP id o125-v6mr7468253iof.173.1539451029127; Sat, 13 Oct 2018 10:17:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 10:17:08 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A6D@SHSMSX104.ccr.corp.intel.com> References: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A58@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A6D@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Sat, 13 Oct 2018 19:17:08 +0200 Message-ID: To: "Gao, Liming" Cc: "Zhu, Yonghong" , Andrew Fish , "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 17:17:10 -0000 Content-Type: text/plain; charset="UTF-8" On 13 October 2018 at 19:12, Gao, Liming wrote: > Ard: > So, could I add this version in the commit message? Python3.5.3 has been tested. > Yes. > And, with this patch, your CI environment can work? Do you find any other issue? > I can build locally on Debian Stretch so the CI environment should work as well. >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Sunday, October 14, 2018 1:05 AM >> To: Gao, Liming >> Cc: Zhu, Yonghong ; Andrew Fish ; edk2-devel@lists.01.org >> Subject: Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 >> >> On 13 October 2018 at 19:03, Gao, Liming wrote: >> > Ard: >> > Do you verify BaseTools with Python35 or Python36? >> > >> >> Python 3.5.3 (default, Sep 27 2018, 17:25:39) >> [GCC 6.3.0 20170516] on linux >> >> >> >> -----Original Message----- >> >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel >> >> Sent: Sunday, October 14, 2018 12:52 AM >> >> To: Zhu, Yonghong ; Andrew Fish >> >> Cc: edk2-devel@lists.01.org >> >> Subject: Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 >> >> >> >> On 13 October 2018 at 18:39, Yonghong Zhu wrote: >> >> > Remove the logic that the Python3 version must larger than 3.6. >> >> > We verified Python3 migration patches on version 3.6 and 3.7. >> >> > for other version we not verified it. >> >> > >> >> > Cc: Ard Biesheuvel >> >> > Cc: Leif Lindholm >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Yonghong Zhu >> >> >> >> I will note that this does not solve Andrew's problem, but nonetheless: >> >> >> >> Reviewed-by: Ard Biesheuvel >> >> Tested-by: Ard Biesheuvel >> >> >> >> > --- >> >> > BaseTools/toolsetup.bat | 7 ------- >> >> > edksetup.sh | 4 ++-- >> >> > 2 files changed, 2 insertions(+), 9 deletions(-) >> >> > >> >> > diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat >> >> > index 0d4028d..d585431 100755 >> >> > --- a/BaseTools/toolsetup.bat >> >> > +++ b/BaseTools/toolsetup.bat >> >> > @@ -314,17 +314,10 @@ set PYTHON3=py -3 >> >> > echo. >> >> > echo !!! ERROR !!! %PYTHON3% not install. >> >> > echo. >> >> > goto end >> >> > ) >> >> > - FOR /F "TOKENS=1,2" %%i IN ('%PYTHON3% --version') DO set VERSION=%%j >> >> > - if /I "%VERSION%" LSS "3.6" ( >> >> > - echo. >> >> > - echo !!! ERROR !!! python version should greater than or equal to version 3.6. >> >> > - echo. >> >> > - goto end >> >> > - ) >> >> > >> >> > :check_freezer_path >> >> > @REM We have Python, now test for FreezePython application >> >> > if not defined PYTHON_FREEZER_PATH ( >> >> > echo. >> >> > diff --git a/edksetup.sh b/edksetup.sh >> >> > index d4e577e..84b3e63 100755 >> >> > --- a/edksetup.sh >> >> > +++ b/edksetup.sh >> >> > @@ -129,13 +129,13 @@ function SetupPython3() >> >> > if [ "$ret" -eq 1 ]; then >> >> > origin_version=$python_version >> >> > export PYTHON3=$python >> >> > fi >> >> > done >> >> > - if [ -z "$origin_version" ] || [ `echo "$origin_version < 3.6" |bc` -eq 1 ]; then >> >> > + if [ -z "$origin_version" ]; then >> >> > echo >> >> > - echo ERROR!!!, python version should greater than or equal to version 3.6. >> >> > + echo ERROR!!!, Please install a Python 3 Tool. >> >> > echo >> >> > return 1 >> >> > fi >> >> > >> >> > >> >> > -- >> >> > 2.6.1.windows.1 >> >> > >> >> _______________________________________________ >> >> edk2-devel mailing list >> >> edk2-devel@lists.01.org >> >> https://lists.01.org/mailman/listinfo/edk2-devel