From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6F0E2203BBB80 for ; Thu, 24 May 2018 07:55:49 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id j186-v6so2722242ita.5 for ; Thu, 24 May 2018 07:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EnP+vQMvCNeXwBViLzg5P7xU+uS1uuZ3UqqTuSOawZw=; b=WRWB/zb0n+3LUNQY3qOf3Gwwcg8VSX3AiN+ICuWlzLD/FahfrRgJtDyUi5pcNCPNQX h4aNsSZLKYABuX8L2FQilrQK1ZjV/vqcAXnsk3cLmK76bPfMWyiRbzj1JwTXdk2pgWpP rwaFOePEjFNo6ehDaGz1LG64ZaheacejQzChI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EnP+vQMvCNeXwBViLzg5P7xU+uS1uuZ3UqqTuSOawZw=; b=HaNMXBfRdYMCgNP8sxEkr+upB2zbCf1yh4lOZvzdZrRCfwuFAD0OQU4MZObsVFdxUW ZQPMfoNyhpUwW40WI2HZBs228Lr/uPdKrgixq70G9MMTY/o5UZj4vpgvP2RbX6darhZ/ VLzl8mZns+DpmJ6Pk9WXL1Ui6HzgXC9p5cVoLyNOcWPwVMIfWFPtqw5Eh2pOSEIERjh5 2EYBVcyzo/G6JFqkd3l5OQm6SX8YSemF1gwWtk0b7Mmj2eSXHbZp6fWWulispGO9bRjs REXNMUvhB2aDJPQG3DJ361oExBFO1iiAxwGwExwEEvSMs3+kG3eerr0gBj8fShdEfedp 01GA== X-Gm-Message-State: ALKqPwf28UNSiBSSTG8Rw7xxNBQWPoVJ+g7Ey/1OnzdghGmeu6FASk9p Mq7WVs1FZrDpWQTYn936ssz3OVsui2QgPeeK1Wk1bd/fzWk= X-Google-Smtp-Source: AB8JxZqqi890PI1uTsiy1rue7dNTRgSEsul6f9EKGLpxBpiqkfCzfKHM6oTGRGzKaUNr0Krulf+COOjf3eytbtLLrQo= X-Received: by 2002:a24:af45:: with SMTP id l5-v6mr9017445iti.106.1527173748793; Thu, 24 May 2018 07:55:48 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Thu, 24 May 2018 07:55:48 -0700 (PDT) In-Reply-To: References: <20180523202121.8125-1-lersek@redhat.com> <20180523202121.8125-3-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 24 May 2018 16:55:48 +0200 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Jordan Justen Subject: Re: [PATCH v2 2/7] OvmfPkg: introduce PciCapPciSegmentLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 14:55:49 -0000 Content-Type: text/plain; charset="UTF-8" On 24 May 2018 at 16:43, Laszlo Ersek wrote: > On 05/24/18 10:08, Ard Biesheuvel wrote: >> On 23 May 2018 at 22:21, Laszlo Ersek wrote: >>> Add a library class, and a BASE lib instance, that are layered on top of >>> PciCapLib, and allow clients to plug a PciSegmentLib backend into >>> PciCapLib, for config space access. >>> >>> (Side note: >>> >> >> For the record: I am fine with keeping this side note in the commit log. > > Appreciated! :) > > (I've found no other comments from you on this patch, so I guess you'll > state something general towards the end.) > Ah yes Reviewed-by: Ard Biesheuvel