public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ming.huang@linaro.org" <ming.huang@linaro.org>,
	 "Wu, Hao A" <hao.a.wu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory
Date: Fri, 19 Apr 2019 20:43:27 +0200	[thread overview]
Message-ID: <CAKv+Gu-MKQ57_Uqvcm6JipGvMx9pB_r1RC7dST7FZeBQeaT1Gw@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu-hqcEhmiW+J+y9nLqpq6tTpvS7Mi_X2WdDQj9oHAnajA@mail.gmail.com>

On Fri, 19 Apr 2019 at 20:38, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 19 Apr 2019 at 20:23, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > Ard,
> >
> > Let's see if we can remove the ESRT access from those
> > paths.  That would be the better fix.
> >
>
> I am not that familiar with this code, but it seems that the only
> reason we access the ESRT at runtime is to check whether a capsule is
> a nested FMP capsule, where the outer GUID is cross referenced against
> the ESRT before checking whether the inner GUID is the FMP guid.
>
> Could we relax this check? FMP capsule can only be dispatched across a
> reboot anyway, and so the runtime capsule handling could accept any
> capsule that has an inner FMP guid.
>
> If not, it means we do need to read the ESRT at runtime, in which case
> my patch is the simplest solution. We would have to clarify the spec
> though.
>

Actually, I might be able to cache just the list of GUIDs at
ReadyToBoot, so we can do the comparisons at runtime.

  reply	other threads:[~2019-04-19 18:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 14:13 [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory Ard Biesheuvel
2019-04-19 17:36 ` [edk2-devel] " Michael D Kinney
2019-04-19 17:42   ` Ard Biesheuvel
2019-04-19 17:53     ` Ard Biesheuvel
2019-04-19 18:08       ` Michael D Kinney
2019-04-19 18:11         ` Ard Biesheuvel
2019-04-19 18:23           ` Michael D Kinney
2019-04-19 18:38             ` Ard Biesheuvel
2019-04-19 18:43               ` Ard Biesheuvel [this message]
2019-04-19 19:46                 ` Michael D Kinney
2019-04-19 20:04                   ` Michael D Kinney
2019-04-20 10:25                     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-MKQ57_Uqvcm6JipGvMx9pB_r1RC7dST7FZeBQeaT1Gw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox