From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=O+hk0Gm9;
 spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194])
 by groups.io with SMTP; Fri, 19 Apr 2019 11:43:40 -0700
Received: by mail-it1-f194.google.com with SMTP id a190so9548391ite.4
        for <devel@edk2.groups.io>; Fri, 19 Apr 2019 11:43:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=pswqf24qHZkWAi5WtP3Qe5fX7xVt8Fb874nHVAsM2Rg=;
        b=O+hk0Gm9LE0LlLB/3w+2Xdq3AH8mPauhHWbbjpLN3eaMMzGen3nJg3GWwJTBrw4d34
         yGxnN/EzKB4VPRuTGmexg9GyiJQ884fioFFvmBG6TQz48CwnDYAcdBQSXbGWY2NH7Ix7
         l694LcTXG3MTDp0dzcbM9tuzp7dZKRE4wltTxvGsA6AsxLnQ0Hll4DmnuGYAm1EU9Jxr
         NFRPzHgJW5aRfli2YeOzhbT4SxKrPDrsqjRuj8Xo9oZ3PKlZ7dXYg72ByCRnLHferQxO
         BchegshVvLSIVu7YEJwHWE8JV07AUjmE8Q0l8ur4Yxg9oreQWW5DRXUOuuurrongwLyj
         iOSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=pswqf24qHZkWAi5WtP3Qe5fX7xVt8Fb874nHVAsM2Rg=;
        b=JBOW6tQJV+SFKJ+uLkqZQlpcuspEAX6TDBBIfqMR1Y/aAFflAUhFSc1AE7iJaJyeyy
         FgAWVG1/r2W1qr3te48RdWb+pDnuIg1gURQ9BcLPbUx0oP98vERvUJXHFCMs5+VMzHk3
         EoQ1bW4mCB3zPNQO4rOiyhYdOiZAadXamjzy5gqpRLhhwKSMyDCboVKczvXipfZb8IxL
         zccooAxd45uC5hisfFdithB9Pr2IdTFrNnx0QDAF3VJ/s/Rdo2SxEZGpeoTxo4JhHgyu
         xbHT/haXfqLuyVjR+l6SVJkGMAejD6OdmdoQETvCY5Dg9pRnXGOLt33yxjn+kLDBnpwZ
         SAAQ==
X-Gm-Message-State: APjAAAX15DzNjUOpLgMOuq23OwO6UsfBwX4gcqiq9Vpv+x9J5+nvYHj1
	RSP7mPVEHDyrbRaKafYdHC2EQkJZCB/B/guPVG99Ow==
X-Google-Smtp-Source: APXvYqwKXELYx6NwvpBQoQ2t8ZqFfevaGbtVFMAUSnK4asB4xqYI9125w/0Z7LBakqCQCgAJBV2EzVvVjnyqni4R/Sw=
X-Received: by 2002:a02:9f19:: with SMTP id z25mr3723907jal.2.1555699419350;
 Fri, 19 Apr 2019 11:43:39 -0700 (PDT)
MIME-Version: 1.0
References: <20190419141319.11084-1-ard.biesheuvel@linaro.org>
 <E92EE9817A31E24EB0585FDF735412F5B9C9B56C@ORSMSX113.amr.corp.intel.com>
 <CAKv+Gu_uhyHHDe7bcH=UMcxYLPkvVTBbgM2=f0iK7N6K7uoYZA@mail.gmail.com>
 <CAKv+Gu982PSXmD65ibnU_LWhO-HdgUmZHk9LS374h6o5veYnow@mail.gmail.com>
 <E92EE9817A31E24EB0585FDF735412F5B9C9B687@ORSMSX113.amr.corp.intel.com>
 <CAKv+Gu8eS0vAN=3X8ATFVSJuKemi4sinZmtWbdFWx1L66TnHXw@mail.gmail.com>
 <E92EE9817A31E24EB0585FDF735412F5B9C9B6C0@ORSMSX113.amr.corp.intel.com> <CAKv+Gu-hqcEhmiW+J+y9nLqpq6tTpvS7Mi_X2WdDQj9oHAnajA@mail.gmail.com>
In-Reply-To: <CAKv+Gu-hqcEhmiW+J+y9nLqpq6tTpvS7Mi_X2WdDQj9oHAnajA@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 19 Apr 2019 20:43:27 +0200
Message-ID: <CAKv+Gu-MKQ57_Uqvcm6JipGvMx9pB_r1RC7dST7FZeBQeaT1Gw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH resend] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, "ming.huang@linaro.org" <ming.huang@linaro.org>, 
	"Wu, Hao A" <hao.a.wu@intel.com>, "Wang, Jian J" <jian.j.wang@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 19 Apr 2019 at 20:38, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 19 Apr 2019 at 20:23, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > Ard,
> >
> > Let's see if we can remove the ESRT access from those
> > paths.  That would be the better fix.
> >
>
> I am not that familiar with this code, but it seems that the only
> reason we access the ESRT at runtime is to check whether a capsule is
> a nested FMP capsule, where the outer GUID is cross referenced against
> the ESRT before checking whether the inner GUID is the FMP guid.
>
> Could we relax this check? FMP capsule can only be dispatched across a
> reboot anyway, and so the runtime capsule handling could accept any
> capsule that has an inner FMP guid.
>
> If not, it means we do need to read the ESRT at runtime, in which case
> my patch is the simplest solution. We would have to clarify the spec
> though.
>

Actually, I might be able to cache just the list of GUIDs at
ReadyToBoot, so we can do the comparisons at runtime.