* [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include
@ 2017-12-08 14:01 Ard Biesheuvel
2017-12-08 14:08 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 14:01 UTC (permalink / raw)
To: edk2-devel, leif.lindholm; +Cc: Ard Biesheuvel
Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC
and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding
the appropriate #include and LibraryClass references, resulting in build
failures when attempting to build the SynQuacer platforms. So add them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 1 +
Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
index 643289131214..e58a2093eb49 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
@@ -16,6 +16,7 @@
#include <Library/BaseMemoryLib.h>
#include <Library/DebugLib.h>
#include <Library/DtPlatformDtbLoaderLib.h>
+#include <Library/IoLib.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Platform/MemoryMap.h>
diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
index 478e0c7d33e9..00c1130906c4 100644
--- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
+++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
@@ -37,6 +37,7 @@ [LibraryClasses]
BaseMemoryLib
DebugLib
DtPlatformDtbLoaderLib
+ IoLib
MemoryAllocationLib
UefiBootServicesTableLib
UefiDriverEntryPoint
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include
2017-12-08 14:01 [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include Ard Biesheuvel
@ 2017-12-08 14:08 ` Leif Lindholm
2017-12-08 14:14 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-12-08 14:08 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Fri, Dec 08, 2017 at 02:01:58PM +0000, Ard Biesheuvel wrote:
> Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC
> and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding
> the appropriate #include and LibraryClass references, resulting in build
> failures when attempting to build the SynQuacer platforms. So add them.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 1 +
> Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> index 643289131214..e58a2093eb49 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> @@ -16,6 +16,7 @@
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/DtPlatformDtbLoaderLib.h>
> +#include <Library/IoLib.h>
> #include <Library/MemoryAllocationLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Platform/MemoryMap.h>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> index 478e0c7d33e9..00c1130906c4 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf
> @@ -37,6 +37,7 @@ [LibraryClasses]
> BaseMemoryLib
> DebugLib
> DtPlatformDtbLoaderLib
> + IoLib
> MemoryAllocationLib
> UefiBootServicesTableLib
> UefiDriverEntryPoint
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include
2017-12-08 14:08 ` Leif Lindholm
@ 2017-12-08 14:14 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-12-08 14:14 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 8 December 2017 at 14:08, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Dec 08, 2017 at 02:01:58PM +0000, Ard Biesheuvel wrote:
>> Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC
>> and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding
>> the appropriate #include and LibraryClass references, resulting in build
>> failures when attempting to build the SynQuacer platforms. So add them.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks. Pushed as 993deafa1fd81b260ae28fff3db851c6b0aa9d74
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-08 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-08 14:01 [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include Ard Biesheuvel
2017-12-08 14:08 ` Leif Lindholm
2017-12-08 14:14 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox