From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::230; helo=mail-it0-x230.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FC782217CE3E for ; Fri, 8 Dec 2017 06:09:28 -0800 (PST) Received: by mail-it0-x230.google.com with SMTP id d16so5021392itj.1 for ; Fri, 08 Dec 2017 06:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ORD5X5wf9+EROlYPDd4t9YmZ55Pb7VwmHP9OvPZCNK4=; b=Rn4tVzQYuicQuaHSkQ/m7VW1MFjDq004GRjJkux7pFGgPeGYBlI/q0mpDnbHOwp1gb G+zX/8ituo9t0JHcB16FLFigo47BLDVX4HIFGPHJcsIszlbL2pJHLSdiQQcnIHLZhfv4 Bf0yMtNpwmmHjrI3vW5GquvULuu8CH5v+nFmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ORD5X5wf9+EROlYPDd4t9YmZ55Pb7VwmHP9OvPZCNK4=; b=DfFFl6F6hgH1VrO9NSPtOglieHKGG7t8Mulw03/t0mQeR6R4XVGu9yBd0Gw5XqEVPe jhjos/Pk8j8aEh9t9CQI/lQkFA2/+26gtEoMCZksz/IYyc44xuSRjjCeJBoRJkrGfoV1 EkXma5ppP9kTm7eh6VNt/yNVJoL3KbXFctpXsUiUqNBfIdTDLRRsgG4ItbolWpCWHW2H wIYywQhmGy3ubq4eiG2VMRGrajpSZDHga68ceP9gXCPTU2iFXiOx+RuWYu9Bd9OiQrWM rtmvpi1oWcyO5/0s5eHrIIe8c3Y9/LLaejUqRTn3XSKZ+a0a8MIG6IZun/rryn14MwO0 ryfw== X-Gm-Message-State: AKGB3mLqEHagJCh/m1Pix3yLK6xeCWuCsqDvx0flDluBYbOyEXsnLCqD rDPAbnru+VAxLtA4tqfiAmtl0TbeHnUeop8lChW0Eg== X-Google-Smtp-Source: AGs4zMa0Gpwp8+vTNzR2jr6Pcj79FmkDXVJKJKg4CmfRNmzsZ6bRaFnSLvsQbXX0++/1096RncuF7P93euOLW9LaVdU= X-Received: by 10.107.180.18 with SMTP id d18mr2794904iof.52.1512742442407; Fri, 08 Dec 2017 06:14:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Fri, 8 Dec 2017 06:14:01 -0800 (PST) In-Reply-To: <20171208140840.tt3cwjoksiuxdhcx@bivouac.eciton.net> References: <20171208140158.31371-1-ard.biesheuvel@linaro.org> <20171208140840.tt3cwjoksiuxdhcx@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 8 Dec 2017 14:14:01 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Silicon/Socionext/SynQuacer/PlatformDxe: add missing IoLib include X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:09:29 -0000 Content-Type: text/plain; charset="UTF-8" On 8 December 2017 at 14:08, Leif Lindholm wrote: > On Fri, Dec 08, 2017 at 02:01:58PM +0000, Ard Biesheuvel wrote: >> Commit ce95ec196da0 ("Silicon/SynQuacer: enable coherent DMA for NETSEC >> and eMMC") introduced a call to MmioOr32 into PlatformDxe without adding >> the appropriate #include and LibraryClass references, resulting in build >> failures when attempting to build the SynQuacer platforms. So add them. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Tested-by: Leif Lindholm > Thanks. Pushed as 993deafa1fd81b260ae28fff3db851c6b0aa9d74