From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Nadav Haklai" <nadavh@marvell.com>,
"Neta Zur Hershkovits" <neta@marvell.com>,
"Kostya Porotchkin" <kostap@marvell.com>,
"Hua Jing" <jinghua@marvell.com>,
"Alexander Graf" <agraf@suse.de>, "Jan Dąbroś" <jsd@semihalf.com>
Subject: Re: [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support
Date: Fri, 1 Sep 2017 10:40:44 +0100 [thread overview]
Message-ID: <CAKv+Gu-MwfF9X8zwb1ob5CkBqpccq3-gU2p+vdXCo_ScwkgvjA@mail.gmail.com> (raw)
In-Reply-To: <CAPv3WKdH=fETT0BZRTvrFJm3aqLFeJ7HEnf7tN8XuJMpMvKJVg@mail.gmail.com>
On 1 September 2017 at 10:39, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Ard,
>
> 2017-09-01 11:26 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>>
>> On 1 September 2017 at 03:37, Marcin Wojtas <mw@semihalf.com> wrote:
>> > Since now SerDes can be properly configured to support 10G
>> > link, add this feature to the Armada 7k/8k network driver
>> > as well. This patch extends low-level configuration routines
>> > with SFI additions, which required two new fields in
>> > PP2DXE_PORT structure (XpcsBase and MpcsBase).
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.0
>> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>>
>> If you need to resend this, please fix your indentation: either
>>
>> Status = Function(xxx, xxx,
>> xxx, xxx, etc);
>>
>> (two spaces indentation relative to the function name)
>>
>> or
>>
>> Status = Function (xxx,
>> xxx,
>> xxx,
>> etc);
>>
>> Other than that
>>
>
> In 5.2.2.4 of https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/52_spacing.html#52-spacing
> there's indeed 2 spaces of indentation relative to function name, but
> shouldn't correct multiline call look following:
>
> Status = Function (
> aaa,
> bbb
> );
> ?
>
There was a lot of discussion about this (unfortunately), but putting
the function name and the closing parenthesis on a separate line is
really not necessary.
next prev parent reply other threads:[~2017-09-01 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 2:37 [platforms: PATCH 0/7] Armada 70x0/80x0 network improvements Marcin Wojtas
2017-09-01 2:37 ` [platforms: PATCH 1/7] Drivers/Net/Pp2Dxe: Move registers' description to macros Marcin Wojtas
2017-09-01 9:22 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support Marcin Wojtas
2017-09-01 9:26 ` Ard Biesheuvel
2017-09-01 9:39 ` Marcin Wojtas
2017-09-01 9:40 ` Ard Biesheuvel [this message]
2017-09-01 9:49 ` Marcin Wojtas
2017-09-01 9:51 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 3/7] Drivers/Net/Pp2Dxe: Support multiple ethernet ports simultaneously Marcin Wojtas
2017-09-01 9:30 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 4/7] Drivers/Net/Pp2Dxe: Increase amount of ingress resources Marcin Wojtas
2017-09-01 9:30 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 5/7] Platforms/Marvell: Update ethernet ports types on A70x0 DB Marcin Wojtas
2017-09-01 9:31 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 6/7] Drivers/Net/Pp2Dxe: Move devices description to MvHwDescLib Marcin Wojtas
2017-09-01 9:33 ` Ard Biesheuvel
2017-09-01 2:37 ` [platforms: PATCH 7/7] Drivers/Net/Pp2Dxe: Enable using ports from different controllers Marcin Wojtas
2017-09-01 9:34 ` Ard Biesheuvel
2017-09-01 9:27 ` [platforms: PATCH 0/7] Armada 70x0/80x0 network improvements Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-MwfF9X8zwb1ob5CkBqpccq3-gU2p+vdXCo_ScwkgvjA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox