From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79ABA21E7490E for ; Fri, 1 Sep 2017 02:38:01 -0700 (PDT) Received: by mail-io0-x230.google.com with SMTP id b2so13454119iof.0 for ; Fri, 01 Sep 2017 02:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kfDkeiLp/sWl/p1Hzr53MylMXtza3r4oaLlG8U6W0ik=; b=FpJxQXD9xs2xrETzYavyeqD1Sf+iaqfOZQNRRuyaddjcYKav072eMPrHiKbdLDQt8Z H4O+kuXDJoWP6iD745OQIH7ovPCnAEKjEOsTNrcPcq2sem5HgvdN+1yUqy7mkqnYFues V9SH/7HSolQ14X0YkpFAt4+nqEnVOIm0KGiLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kfDkeiLp/sWl/p1Hzr53MylMXtza3r4oaLlG8U6W0ik=; b=Qp/gEl8BikmKldU+G7oeim30tjvyUq8AkNdLN+HKy8ZgAEpZQt5X+iXvNoyNDkFNQi X0Ih11M45A4hsYzOMnnJI6DMSKDuP+PfCh14yKt4mXj7h3Q4qjRCg2+rlwcVdurLg3TD AgprJCqBJatPGGL08weeX+hQm4ysdWWcN7R4Dlyy/cnSYXi5T9XLNRa1JDWWEumlpndv QB3rn3vZMgt1EC6GMHImerd405sta604b6qA5dWBiAHyzWFyfjhgxzhvnP2hmbRySzkG yrBn8RnDENTQuDaCP2ydVzuPT33QonbaMcN5LP3u+AifdBJqFSyHoWuZnHP34iAABNzs /DGg== X-Gm-Message-State: AHPjjUiA5OOnRzcIC3U3E3OqmFOOL0j32yMY/HRjtZ6yH/GrzgjQ9lW+ QEFWd+EgYEZ3OOp44XxbpzSfMeplc9eo X-Google-Smtp-Source: ADKCNb72NQ5gs80cIT9BHCstR/KaM5x7Ytfc2SmkaBOMFtUplaaxdrRPq1L0a4jPLNuzXhknfe6LqUwzwkpzr6b+tEs= X-Received: by 10.36.8.138 with SMTP id 132mr36646itc.162.1504258845189; Fri, 01 Sep 2017 02:40:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:40:44 -0700 (PDT) In-Reply-To: References: <1504233451-6455-1-git-send-email-mw@semihalf.com> <1504233451-6455-3-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 10:40:44 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , =?UTF-8?B?SmFuIETEhWJyb8Wb?= Subject: Re: [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 09:38:01 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 10:39, Marcin Wojtas wrote: > Hi Ard, > > 2017-09-01 11:26 GMT+02:00 Ard Biesheuvel : >> >> On 1 September 2017 at 03:37, Marcin Wojtas wrote: >> > Since now SerDes can be properly configured to support 10G >> > link, add this feature to the Armada 7k/8k network driver >> > as well. This patch extends low-level configuration routines >> > with SFI additions, which required two new fields in >> > PP2DXE_PORT structure (XpcsBase and MpcsBase). >> > >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Marcin Wojtas >> >> If you need to resend this, please fix your indentation: either >> >> Status = Function(xxx, xxx, >> xxx, xxx, etc); >> >> (two spaces indentation relative to the function name) >> >> or >> >> Status = Function (xxx, >> xxx, >> xxx, >> etc); >> >> Other than that >> > > In 5.2.2.4 of https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/52_spacing.html#52-spacing > there's indeed 2 spaces of indentation relative to function name, but > shouldn't correct multiline call look following: > > Status = Function ( > aaa, > bbb > ); > ? > There was a lot of discussion about this (unfortunately), but putting the function name and the closing parenthesis on a separate line is really not necessary.