From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.3075.1580862182813075392 for ; Tue, 04 Feb 2020 16:23:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=HIhZp6Mj; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id b17so594800wmb.0 for ; Tue, 04 Feb 2020 16:23:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6rKb+RjgV6OV2HV7QkaoeE9cAPuhbUryTryr8STxd2w=; b=HIhZp6Mj+Bn1DN5vwPMGv64phEBRk+KNoUb3Wv2e4Dq6LP2LY/Hv8su9rgdfI+y24w K5Ro2xzN58R+utWPSKZkgr3fSQ7y2hsjqOOpNry8cpIUtbqatM8x0ozzqdQ44YEjunHM t3lzECgIYGe6OFxCPGOQWGwZ4rH1qWwp7a38cNiTffW0lL6Suj7wyJ3tJHzBG+8KRq5g RYiGHN7dXBckOHc7uY6n1mVmbgItouL9OvuzocdVc1swWrtZZliFOwVZDSF/PMoLmh3G rtJUq874p6YcJ8zdTqaYtUh6gf1XEP3DsGctDkkuKwjLjefs0xLU4eu8uOmdt8GfKYWo PZ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6rKb+RjgV6OV2HV7QkaoeE9cAPuhbUryTryr8STxd2w=; b=GVKWy9Bsu9zacVLLOj7Qf6x/CZpxnayoxPzUC1otErz/AkGIhf37/j3jgaqjh4eLg2 62SAPLn8BiQkiJzfKB4ttgdBDxTfHI/oAVTbKoJMia7jGibvGR12AezKSqVoIP0d1n7k Kk2p0vYyQA5gdo7vkQj7iHH7dsI5TRJM4nmmSy1RQQZmwNHvGzp6MEuPU7XiUnY8/hnq OWey8vpwYV+QQFB/oIXWiDhB2BONbxoY8Ch6vur3+hawvYtLgM9o5yBHuQcjs9xQ0AO1 l7I1F69V8/XbJ71oCJAQUx0C37ys3ADSVUd/5TR4nhYtHkWMlRE8o5FbXpIvXlM/4BtJ nSHg== X-Gm-Message-State: APjAAAXr9ACv+3/zLY2PEYBf/5L2iM5M3IOsBGndmp9+g4WA+hxWlWTF gIoTW+tKRzPBtBo6GMbR2ww7M5nQoFBzWghk6eotZQ== X-Google-Smtp-Source: APXvYqzb5PYdL8CUJ4br16LuJB5um4AgCTRrIzOvEoctFvOuDNWLsclPu8vaigPbDBOz7tF030NUfLaJCjSQLtXSDA4= X-Received: by 2002:a1c:bc46:: with SMTP id m67mr1631623wmf.40.1580862181315; Tue, 04 Feb 2020 16:23:01 -0800 (PST) MIME-Version: 1.0 References: <20200129214412.2361-1-lersek@redhat.com> In-Reply-To: <20200129214412.2361-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Wed, 5 Feb 2020 00:22:50 +0000 Message-ID: Subject: Re: [PATCH v2 00/11] support QEMU's "SMRAM at default SMBASE" feature To: Laszlo Ersek Cc: edk2-devel-groups-io , Anthony Perard , Jiewen Yao , Jordan Justen , Julien Grall Content-Type: text/plain; charset="UTF-8" On Wed, 29 Jan 2020 at 21:44, Laszlo Ersek wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 > Repo: https://github.com/lersek/edk2.git > Branch: smram_at_default_smbase_bz_1512_wave_1_v2 > Supersedes: <20190924113505.27272-1-lersek@redhat.com> > > V1 is archived at: > - http://mid.mail-archive.com/20190924113505.27272-1-lersek@redhat.com > - https://edk2.groups.io/g/devel/message/47924 > > Igor's patch set, mentioned in the v1 blurb, has been merged into QEMU > meanwhile. The relevant QEMU commit is f404220e279c ("q35: implement > 128K SMRAM at default SMBASE address", 2020-01-22). > > In v2: > - trim the Cc list > > - pick up Jiewen's R-b for patches #1 through #9, from: > - http://mid.mail-archive.com/74D8A39837DF1E4DA445A8C0B3885C503F7CBCB2@shsmsx102.ccr.corp.intel.com > - https://edk2.groups.io/g/devel/message/48166 > > - add patch #10, and update patch #11, for satisfying Jiewen's condition > on his R-b. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Julien Grall > > Thanks, > Laszlo > > Laszlo Ersek (11): > OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase > OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro > defs > OvmfPkg/IndustryStandard: add MCH_DEFAULT_SMBASE* register macros > OvmfPkg/PlatformPei: factor out Q35BoardVerification() > OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (skeleton) > OvmfPkg/PlatformPei: assert there's no permanent PEI RAM at default > SMBASE > OvmfPkg/PlatformPei: reserve the SMRAM at the default SMBASE, if it > exists > OvmfPkg/SEV: don't manage the lifecycle of the SMRAM at the default > SMBASE > OvmfPkg/SmmAccess: close and lock SMRAM at default SMBASE > OvmfPkg: introduce PcdCsmEnable feature flag > OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real) > For the series, Reviewed-by: Ard Biesheuvel > OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 106 +++++++++++--------- > OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +++- > OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4 + > OvmfPkg/OvmfPkg.dec | 11 ++ > OvmfPkg/OvmfPkgIa32.dsc | 4 + > OvmfPkg/OvmfPkgIa32X64.dsc | 4 + > OvmfPkg/OvmfPkgX64.dsc | 4 + > OvmfPkg/OvmfXen.dsc | 3 + > OvmfPkg/PlatformPei/AmdSev.c | 24 ++++- > OvmfPkg/PlatformPei/MemDetect.c | 94 ++++++++++++++--- > OvmfPkg/PlatformPei/Platform.c | 24 +++++ > OvmfPkg/PlatformPei/Platform.h | 7 ++ > OvmfPkg/PlatformPei/PlatformPei.inf | 2 + > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 7 ++ > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 1 + > OvmfPkg/SmmAccess/SmmAccessPei.c | 6 ++ > OvmfPkg/SmmAccess/SmmAccessPei.inf | 1 + > OvmfPkg/SmmAccess/SmramInternal.c | 25 +++++ > OvmfPkg/SmmAccess/SmramInternal.h | 8 ++ > 19 files changed, 285 insertions(+), 71 deletions(-) > > -- > 2.19.1.3.g30247aa5d201 >