From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 92A3C201B03EE for ; Wed, 20 Feb 2019 03:05:01 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id z131so14223707itf.5 for ; Wed, 20 Feb 2019 03:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fvY+BCn3WtSiiA1ohpTzOo8PRwakBz3kRNbw5ZlIZP8=; b=yUt8tWuAWGcVuh4VptR8gpx538hyGjI4ABafQnzVebsG7gTm5KY4szVRPGjFR1/LU8 E197V2P03QZjISqzq+a0w1jIZ4X+m+zTUzkTZ6weN+aYhArkvZxaYFMiVEdNA/S3WBUK aBcor9x59EfTtztDBmpGYag7md54vORY9TrXDUvoTTJWIDxH5v3zQ2iVMROt9R9EITIR phvNeORNPIqamJgjK/W/NtsUeMXoTIExumQ72KWBBpo2zCrYE6x78hiWy7+S45yewE01 qtHqQeH+TBw8p/pple/j2OsAmQ4XxZcLFo7esqUUO0ErDqBky7y0VCM6hpMj28199aGZ aR5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fvY+BCn3WtSiiA1ohpTzOo8PRwakBz3kRNbw5ZlIZP8=; b=H83sZSvF7RkGYkJcFj7Pi2Ky62MYjDCt6vlfnjTPCbbnMUPaaBenxejQ1v47oSL+Aq ARwXXzfUC6D37W/YEXTaHHODeEX6zK1DBwEDXtlX2/tcspktNzpX1FaGutc5gMa7KtJc 7rjB+RYX//dXXorF1yPU/TW0ZSInKtc79KTe2l4o6E4/BQoY8rWUJPZjyKTwy9GKTlTq sI5x5o0OTrdeedtPAkWRuiZxROTCnHWYjSnnop4uv+AhtsIbTgH7dTt/3/kr8+zSr/2a H5n7dgNqpjfeRVRZk0jdpGDDe4yPQuR8lFgPhMlpNkhixEbyLJiwiSAv//xMltcNEBS6 taTQ== X-Gm-Message-State: AHQUAuaHbfrBMJEQJPjt3IZ+LqPjIAGRnJe2m8XFSUmJ1M8y6yv5NYCV kx+cqPd8MW17+bLdLOEU9Cl+aKL/ocYdcwhpCY8RPA== X-Google-Smtp-Source: AHgI3IZPcs3Cc1g6iMwJ9RERhebgTXraoxkoTBmyU985o1bVbdM+Jr4NGgpBJgNM5JpzKN0AhJ2UZr/PU1G2TWo/Oj0= X-Received: by 2002:a6b:6511:: with SMTP id z17mr19467124iob.173.1550660700589; Wed, 20 Feb 2019 03:05:00 -0800 (PST) MIME-Version: 1.0 References: <7a0d5c95fdeee0e68f54c8a6a0fbe37c85e76774.1548892644.git.jbrasen@nvidia.com> In-Reply-To: From: Ard Biesheuvel Date: Wed, 20 Feb 2019 12:04:49 +0100 Message-ID: To: "Wu, Hao A" Cc: Jeff Brasen , "edk2-devel@lists.01.org" , Edgar Handal , Marcin Wojtas Subject: Re: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 11:05:01 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 20 Feb 2019 at 02:19, Wu, Hao A wrote: > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Sunday, February 03, 2019 8:39 PM > > To: Wu, Hao A > > Cc: Jeff Brasen; edk2-devel@lists.01.org; Edgar Handal; Marcin Wojtas > > Subject: Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit > > IO widths > > > > On Fri, 1 Feb 2019 at 06:55, Wu, Hao A wrote: > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Jeff > > > > Brasen > > > > Sent: Thursday, January 31, 2019 7:59 AM > > > > To: edk2-devel@lists.01.org > > > > Cc: Edgar Handal; Jeff Brasen > > > > Subject: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit > > IO > > > > widths > > > > > > > > From: Edgar Handal > > > > > > > > Use 16-bit and 32-bit IO widths for SDMMC MMIO to prevent all register > > > > accesses from being split up into 8-bit accesses. > > > > > > > > The SDHCI specification states that the registers shall be accessable in > > > > byte, word, and double word accesses. > > > > > > > Acked-by: Ard Biesheuvel > > Ard, > > Really sorry for missing your 'Acked-by' tag. > It came to me after I pushed the commit. > > Sorry again for this. > No worries