From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdePkg/PciSegmentLibSegmentInfo: fix typo in PciSegmentBitFieldAnd*()
Date: Tue, 5 Sep 2017 16:49:20 +0100 [thread overview]
Message-ID: <CAKv+Gu-NRz4kSK9MhCVgCnCnfjwnoL1WCwaFoa9TfS2oKX7QOg@mail.gmail.com> (raw)
In-Reply-To: <20170905145029.292860-1-ruiyu.ni@intel.com>
On 5 September 2017 at 15:50, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> index 7b7324d673..e0bdb16911 100644
> --- a/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> +++ b/MdePkg/Library/PciSegmentLibSegmentInfo/PciSegmentLibCommon.c
> @@ -381,7 +381,7 @@ PciSegmentBitFieldAnd8 (
> PCI_SEGMENT_INFO *SegmentInfo;
>
> SegmentInfo = GetPciSegmentInfo (&Count);
> - return MmioBitFieldOr8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> + return MmioBitFieldAnd8 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> }
>
> /**
> @@ -752,7 +752,7 @@ PciSegmentBitFieldAnd16 (
> PCI_SEGMENT_INFO *SegmentInfo;
>
> SegmentInfo = GetPciSegmentInfo (&Count);
> - return MmioBitFieldOr16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> + return MmioBitFieldAnd16 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> }
>
> /**
> @@ -1119,7 +1119,7 @@ PciSegmentBitFieldAnd32 (
> PCI_SEGMENT_INFO *SegmentInfo;
>
> SegmentInfo = GetPciSegmentInfo (&Count);
> - return MmioBitFieldOr32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> + return MmioBitFieldAnd32 (PciSegmentLibGetEcamAddress (Address, SegmentInfo, Count), StartBit, EndBit, AndData);
> }
>
> /**
> --
> 2.12.2.windows.2
>
prev parent reply other threads:[~2017-09-05 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 14:50 [PATCH] MdePkg/PciSegmentLibSegmentInfo: fix typo in PciSegmentBitFieldAnd*() Ruiyu Ni
2017-09-05 15:49 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-NRz4kSK9MhCVgCnCnfjwnoL1WCwaFoa9TfS2oKX7QOg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox