From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD4BD21C9127B for ; Sun, 20 Aug 2017 10:44:07 -0700 (PDT) Received: by mail-it0-x230.google.com with SMTP id 76so24215020ith.0 for ; Sun, 20 Aug 2017 10:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8r2QfIt98Q1QcMwxKNUNKX7iCI9OtcTaYSuwpfFTg58=; b=eKf1IH6M9jLKfMmeYs2OUsc74kYpfXfqCqZ3TN5/lvFi0cj3gkNspOpOkob6Z6ZccU QRcEuJP2HVn5+x81fjxF0n9aR7VsAwU+4U8ngP3WxfDEOSFJK/RP8jrs8sM72uwuxbxF l0DJLn1b8ysFVBegTDRNnCd8sz1FZvqf1ZIV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8r2QfIt98Q1QcMwxKNUNKX7iCI9OtcTaYSuwpfFTg58=; b=l1Gblg6pMMC0A/TPLMpZ6cWYgSTURdDdvEF7ZSYPGjrhOjcctx383Fx+qQt4dhAwR2 ixjbECJCU5pheCOPs200lQnmP70Pp3CShWRh11I2dfDe+QVPFddAEoodr83kW6oXWbfG RhvnfQKQx4uiQyv6/bpxR7Grwk8HG6UOEuC9z/jDVP4QTkXn2oLkG/C/UvYi/MAJLWOJ hJcL29rJktpJPn++DWnm4Cayczox6WIwR982I0807FlcW5G3ffmo7qe7rMbyAnHiM/yL 1JVzJedSKeXd/tWmI1r+3CX/9bFJwkA0eoy0f/FHZtPGht8rGXY54/BVUeynlLuaVMk4 gBoQ== X-Gm-Message-State: AHYfb5jj1s6kD8pL7aM6XhYzhi8WoCye0gnSAWKEHff7XXrzfvTnzsyA gxGFQFGs2xZhMtFSOt7XAIjPZ4EMVY6J X-Received: by 10.36.20.200 with SMTP id 191mr3772793itg.40.1503251197713; Sun, 20 Aug 2017 10:46:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Sun, 20 Aug 2017 10:46:37 -0700 (PDT) In-Reply-To: <20170819214114.8140-3-alan@softiron.com> References: <20170819214114.8140-1-alan@softiron.com> <20170819214114.8140-3-alan@softiron.com> From: Ard Biesheuvel Date: Sun, 20 Aug 2017 18:46:37 +0100 Message-ID: To: Alan Ott Cc: Leif Lindholm , "edk2-devel@lists.01.org" , linaro-uefi Subject: Re: [PATCH edk2-platforms 2/2] Platform/AMD/OverdriveBoard: Re-enable the second SATA Controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 17:44:08 -0000 Content-Type: text/plain; charset="UTF-8" On 19 August 2017 at 22:41, Alan Ott wrote: > The comment indicating that only the first SATA controller is operational > on SoftIron-branded OverDrive 3000 boards is incorrect. Re-enable the > second SATA controller. > > Signed-off-by: Alan Ott > Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Ard Biesheuvel > --- > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > index f256ffb..2881de3 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -409,14 +409,10 @@ DEFINE DO_FLASHER = FALSE > gArmTokenSpaceGuid.PcdGicDistributorBase|0xE1110000 > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xE112F000 > > - # > - # AMD's B1 based Overdrive has 14 SATA ports across 2 controllers. However, > - # it appears that Softiron's Overdrive 3000, which is also B1 based, does > - # not have the second SATA controller enabled, and any attempts to use it > - # will crash the firmware. So use the first controller only. > - # > + # SATA Ports > gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8 > - gAmdStyxTokenSpaceGuid.PcdSataPortMode|0xffff > + gAmdStyxTokenSpaceGuid.PcdSata1PortCount|6 > + gAmdStyxTokenSpaceGuid.PcdSataPortMode|0x0fffffff > > # PCIe Support > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000 > -- > 2.9.3 >