public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v3 3/5] MdePkg/DxeServicesLib: introduce AllocatePeiAccessiblePages routine
Date: Tue, 29 May 2018 18:19:51 +0200	[thread overview]
Message-ID: <CAKv+Gu-Ou5E2akcFb4T_ayUMSCS=uTNOk9w=7MOoRujOJkNyCg@mail.gmail.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B8A5C066@ORSMSX113.amr.corp.intel.com>

On 29 May 2018 at 18:09, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> Jiewen,
>
> I see what you mean.  It is not the submitting of
> capsules you are referring to.  It is the processing
> if capsules in the PEI phase that depends on some
> things being setup in DXE phase and DXE phase needs
> to know if PEI is in IA32 mode.
>
> So I agree that the commit message could add capsule
> processing to the list of features that can use this
> new service.
>
> The logic in that file is using PcdDxeIplSwitchToLongMode.
> That PCD is TRUE when PEI is IA32 and DXE is X64.  But it
> is ignored when  PEI and DXE are both X64 and could be
> TRUE or FALSE.  Is there a logic issue here with using that
> PCD when PEI and DXE are both X64?
>

Hi all,

The reason I disregarded this particular case in my series is that
this code is already specific to X64. However, given the discussion
you are having, I guess the logic of looking at EfiFreeMemoryTop [at
runtime] combined with the various [build time] PCD values could help
to refine this case as well.


  reply	other threads:[~2018-05-29 16:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 14:40 [PATCH v3 0/5] Abstract allocation of PEI accessible memory Ard Biesheuvel
2018-05-28 14:40 ` [PATCH v3 1/5] OvmfPkg/PlatformBootManagerLib: add missing report status code call Ard Biesheuvel
2018-05-28 14:40 ` [PATCH v3 2/5] ArmVirtPkg/PlatformBootManagerLib: " Ard Biesheuvel
2018-05-28 14:40 ` [PATCH v3 3/5] MdePkg/DxeServicesLib: introduce AllocatePeiAccessiblePages routine Ard Biesheuvel
2018-05-28 14:59   ` Laszlo Ersek
2018-05-29  3:34     ` Gao, Liming
2018-05-29  1:37   ` Zeng, Star
2018-05-29 15:18     ` Yao, Jiewen
2018-05-29 15:31       ` Kinney, Michael D
2018-05-29 15:36         ` Yao, Jiewen
2018-05-29 16:09           ` Kinney, Michael D
2018-05-29 16:19             ` Ard Biesheuvel [this message]
2018-05-29 16:41               ` Yao, Jiewen
2018-05-30  0:58             ` Zeng, Star
2018-05-28 14:40 ` [PATCH v3 4/5] MdeModulePkg/DxeCorePerformanceLib: use AllocatePeiAccessiblePages Ard Biesheuvel
2018-05-29  1:33   ` Zeng, Star
2018-05-28 14:40 ` [PATCH v3 5/5] MdeModulePkg/FirmwarePerformanceDataTableDxe: " Ard Biesheuvel
2018-05-29  1:32   ` Zeng, Star
2018-05-29  8:49 ` [PATCH v3 0/5] Abstract allocation of PEI accessible memory Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu-Ou5E2akcFb4T_ayUMSCS=uTNOk9w=7MOoRujOJkNyCg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox