Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 1 September 2017 at 12:17, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote:
>> On 1 September 2017 at 12:12, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> > Adding Grant,
>> >
>> > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote:
>> >> Clean up the device tree source file, by switching to Tianocore
>> >> conventions for line endings and whitespace etc, and by replacing
>> >> open coded values with symbol constants and/or phandle references.
>> >
>> > 1: All for the getting rid of open coding.
>> >
>> > 2: As for the line endings/whitespace, I am less convinced.
>> >
>> > It is its own (and very specific) file format, it is not
>> > edk2-specific, and just like (GNU)Makefiles and shellscripts they
>> > originated in a CR-free environment.
>>
>> Yeah, that's a good point actually. Ideally, we'd just import this
>> mythical, separate DT repository that is disjoint from the kernel
>> entirely.
>
> That was the subtext, yes :)
>

I should note that the only other public AMD Seattle DT is in the
kernel tree, and it is slightly out of date afaik. I proposed updates
in the past, but nobody seems to care