From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 95C4421E74908 for ; Fri, 1 Sep 2017 04:17:21 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id d78so14270948ioe.4 for ; Fri, 01 Sep 2017 04:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hH4REiGeXd84KjRgvWu5zNFxcgpJfH1QQADQARWpFuI=; b=HVPgYl13tT++eQE1DgkHIMWDLNz/60vTK2ink3P86P6wjB+NeHlT2KqaiBKvfEQb+L 9/o91IFKWSphRfpH8kcFoWixJD7RB6zZijjDn9PW5C3C5wp1YKKz+8Qxcbf9RodqgFdI Yz+A8VUaJWfMqPE6CaIHDzmdztD2/cHnPjmmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hH4REiGeXd84KjRgvWu5zNFxcgpJfH1QQADQARWpFuI=; b=RqN78BC0BWZeQRh6vffU2HET13MlcpnHJt8O2B85S+EVyLkK8bJ9OL0TB1jdUei2q7 jcOuN/Hqu6mb+XqSe+ssygn5eeqobUjanllYWdLujXBoBVsC5WBlWc0RTqMjbpojXSd7 l3zhqNRH0p4ZdWZm/El15I3kPyih7OWdBwzF2SrdW/WqlIIxwfyI6MNyCfvQhCxGGIZM wUscSSoY45/tmGOuZy4IBRXL6wl4rWlUk5Yu64neAIaYsgwSdR087xhphLqnS36yXFT7 Z4Qto/G3j+fgkY4eFJv+8fmqA91laeZT63G+QfDPdpeaNkui1plIWyrvufUl4EWFk2Ls PlZg== X-Gm-Message-State: AHPjjUg9dHeAjsrxOfg0sMPe19p6VAnCD8/sRCYzdJyOYoqFmyiSroqh 6StM0JCfhoyNej+Ue/ebJcp0eIa06CCPzSI= X-Google-Smtp-Source: ADKCNb7qV2WXcQh7avnVy/AzqldZXeJafm0RAxF8wuBuny/LUV//B782VA+AMkV/ykpLYrbAc69kDVaX5cRSYcQp+3k= X-Received: by 10.36.170.9 with SMTP id b9mr236415itf.63.1504264805489; Fri, 01 Sep 2017 04:20:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 04:20:04 -0700 (PDT) In-Reply-To: <20170901111756.dizvq62ohkctljkq@bivouac.eciton.net> References: <20170831130830.12833-1-ard.biesheuvel@linaro.org> <20170831130830.12833-3-ard.biesheuvel@linaro.org> <20170901111200.z2vr5iijgxj2hgy6@bivouac.eciton.net> <20170901111756.dizvq62ohkctljkq@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 12:20:04 +0100 Message-ID: To: Leif Lindholm Cc: Alan Ott , "edk2-devel@lists.01.org" , Grant Likely Subject: Re: [PATCH edk2-platforms v2 2/4] Platform/OverdriveBoard: clean up device tree source file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 11:17:21 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 12:17, Leif Lindholm wrote: > On Fri, Sep 01, 2017 at 12:14:53PM +0100, Ard Biesheuvel wrote: >> On 1 September 2017 at 12:12, Leif Lindholm wrote: >> > Adding Grant, >> > >> > On Thu, Aug 31, 2017 at 02:08:28PM +0100, Ard Biesheuvel wrote: >> >> Clean up the device tree source file, by switching to Tianocore >> >> conventions for line endings and whitespace etc, and by replacing >> >> open coded values with symbol constants and/or phandle references. >> > >> > 1: All for the getting rid of open coding. >> > >> > 2: As for the line endings/whitespace, I am less convinced. >> > >> > It is its own (and very specific) file format, it is not >> > edk2-specific, and just like (GNU)Makefiles and shellscripts they >> > originated in a CR-free environment. >> >> Yeah, that's a good point actually. Ideally, we'd just import this >> mythical, separate DT repository that is disjoint from the kernel >> entirely. > > That was the subtext, yes :) > I should note that the only other public AMD Seattle DT is in the kernel tree, and it is slightly out of date afaik. I proposed updates in the past, but nobody seems to care