From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C575B21109390 for ; Mon, 11 Jun 2018 01:54:23 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id s26-v6so23015456ioj.4 for ; Mon, 11 Jun 2018 01:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3aEXj6F3VhJG3PKY6iymdJk/PQR6YoNfpbLXzT/I4pI=; b=Qz2o7zf/qdfvm6Zw700ds04brbYalE1MC1gtsRp1ZjykvoY5k3KEJ/RzTTo4gsDnLo X9BHP5DMzeY5kKtJ88JTGCH8sDiY+n/plX26DNWS8OksYLpYIzIYTxrKBQNJQ2ixEbtA /MIpFRQ34nQoAG2aeuEDhBWX9R1V8mUTM7taw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3aEXj6F3VhJG3PKY6iymdJk/PQR6YoNfpbLXzT/I4pI=; b=L/bs2IqkfQJ+riDzO/UXwChGPiRsFBGE56m+XdO6IWHaSUn1A0cl72bwwYFk6UXe7M u9IoH5EqLlG3GOaI24HFp9iHH7NB72dlhKSuwEsBNh8te+WRpQPbos3/S2mBA+JD1S+B /nsgbSSOKrdcwKDLSyzy4KBd43HqEbNo/7DbMlh1O/dns13YhrEBNtNXskiPbfajYTJk pAbgZGG2PCADOP/8p44rtsbh+NV+w7rkPsDL383elygTvOmxJzEJKAzAz1vEK6rjAn4w 0RQspq2aAa0/KjL3OqNRsb+0PM30/z7J4OdRDidCeU+kUi8N1o8sotv+9Zzje7XIzfrp EsCQ== X-Gm-Message-State: APt69E0wa/x0xdWsEtWsyP79h3DJeXW2mqTtgTBG4GZv0UYc4R2azMH0 5QQXJ6RYNHS+EisU54pMke67sct6+6EF82MobTfdsw== X-Google-Smtp-Source: ADUXVKKoGYU0kZT7RJIqqCv8IJD4pIqgevp+brhJUxpc8hcjxLrDEdE6fvOVlFUTOIoxecv+3lfr9cVhYsP2wyarxrE= X-Received: by 2002:a6b:4a09:: with SMTP id w9-v6mr3368319iob.277.1528707263057; Mon, 11 Jun 2018 01:54:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 11 Jun 2018 01:54:22 -0700 (PDT) In-Reply-To: References: <20180607091003.8687-1-ard.biesheuvel@linaro.org> <6f89e8bc-2aef-d7d8-bec4-b491506b2a34@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB54B8C@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 11 Jun 2018 10:54:22 +0200 Message-ID: To: "Wu, Hao A" Cc: "Zeng, Star" , "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to DEBUG_BLKIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 08:54:24 -0000 Content-Type: text/plain; charset="UTF-8" On 11 June 2018 at 10:38, Wu, Hao A wrote: > Hi Ard, > > After a quick check on the behavior of other storage device drivers, it seems > to me that they are not using the same debug levels for this kind of debug > message: > > ATA and USB mass storage - BLKIO > NVM Express - VERBOSE > SD/eMMC - INFO > SCSI - actually no such debug message > > My preference is to use the 'BLKIO' for the SD/eMMC case, since literally, it > seems the best fit and the majority of the drivers are using this level. > Or maybe we can use a combination of (DEBUG_BLKIO | DEBUG_VERBOSE). > > Ard and Star, what's your thought? > I am happy to stick with the patch as I proposed it, i.e., DEBUG_BLKIO only >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Monday, June 11, 2018 4:15 PM >> To: Zeng, Star >> Cc: edk2-devel@lists.01.org; Laszlo Ersek; Wu, Hao A >> Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print to >> DEBUG_BLKIO >> >> On 8 June 2018 at 05:15, Zeng, Star wrote: >> > Good patch. >> > >> > Another choice is to use DEBUG_VERBOSE. >> > We see other driver uses DEBUG_VERBOSE for BlockIo service (Hao can >> comment on that). >> > We'd better to align them for consistency. >> > >> >> Hao, >> >> Do you have any preference regarding the exact priority level we will >> use for this particular DEBUG() print? >> >> Thanks, >> Ard. >> >> >> > -----Original Message----- >> > From: Laszlo Ersek [mailto:lersek@redhat.com] >> > Sent: Friday, June 8, 2018 1:23 AM >> > To: Ard Biesheuvel ; edk2-devel@lists.01.org >> > Cc: Zeng, Star >> > Subject: Re: [edk2] [PATCH] MdeModulePkg/EmmcDxe: demote DEBUG print >> to DEBUG_BLKIO >> > >> > On 06/07/18 11:10, Ard Biesheuvel wrote: >> >> Lower the priority of the DEBUG print in EmmcReadWrite(), which is >> >> emitted for each read or write operation to the eMMC device, which >> >> clutters up the log output of builds created with DEBUG_INFO enabled. >> >> >> >> Suggested-by: Pipat Methavanitpong >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> >> --- >> >> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 5 ++++- >> >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> >> b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> >> index e1d0f394a954..f6b230514b71 100644 >> >> --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> >> +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c >> >> @@ -901,7 +901,10 @@ EmmcReadWrite ( >> >> if (EFI_ERROR (Status)) { >> >> return Status; >> >> } >> >> - DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x >> Event %p with %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba, >> BlockNum, (Token != NULL) ? Token->Event : NULL, Status)); >> >> + DEBUG ((DEBUG_BLKIO, >> >> + "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p with %r\n", >> >> + IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockNum, >> >> + (Token != NULL) ? Token->Event : NULL, Status)); >> >> >> >> Lba += BlockNum; >> >> Buffer = (UINT8*)Buffer + BufferSize; >> >> >> > >> > Reviewed-by: Laszlo Ersek