From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED2232119620F for ; Wed, 12 Dec 2018 06:19:49 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id s22so14897589ioc.8 for ; Wed, 12 Dec 2018 06:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CTZeKWQY7hLstkY9Uh+cxGkYA3AqZEIluLPJaqoCTQ0=; b=bU59JtuEbugXzf4WYvvPe74Mk2otoOXTCf5TlnZEeXikxPbdGG+U9eXh+WtzzrI/TW CzFN4EWuj3utm8++OtZBXxO93BJvZMVbEQKd1VPguhfa5silMejbmZqFWZfa1X2hUzHi r4rRhRNlfoCDxE/V5fO1qtb/aJQ15OtQepSYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CTZeKWQY7hLstkY9Uh+cxGkYA3AqZEIluLPJaqoCTQ0=; b=aMXFwuuce2Vz1Pxe8Kavk3MEP63M6+udsLcSRiwlFv7SJM4WNvq/Sjz3XEDv+zrB0d esf9LZI9fr4D2WpZ3CcYztgShBOKtx6aJyWlkJacARgzXLO/FdEKW5aoG1O+9fDbcHQT aNY0qRhV3Dg7S2w0XvFRRTL0EbjS2yLkCislmUPq6W/OsojXcHkuB2mC1EFlf6eGGffY i+gD+OAYcBh8Y8PvAM9KEy/9WeXvHbW7OwPW9LFO93pXs0HC3mCH1v7qyymMgAsFHF4V gDlrvEHmwe7eHy7qmgU98Sq1PFkiLfsUTaFV2cQNasXbcqDSP3DuDmd9t6a5PAbjXp3i 6hGg== X-Gm-Message-State: AA+aEWbKaDJIqSIGh9QhiOc4V48ZYqqOUWCH/suniuEJUxQw2/CfJ6F5 2A+KwhkGxgnv5sYEzGGNLZgqJYeyuK3rbUX+TcDggg== X-Google-Smtp-Source: AFSGD/XgklVVMbca1fzUCZ3Lb4BUFCSNnP5CLadX/1BGqNsl5pdeAuxm05iPU1vcVV5zUaua0ktrVGjSGfrHd6OR5/E= X-Received: by 2002:a5e:c202:: with SMTP id v2mr1281063iop.60.1544624389084; Wed, 12 Dec 2018 06:19:49 -0800 (PST) MIME-Version: 1.0 References: <20181212103308.8099-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38B9CB@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38BA28@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E38BA28@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 12 Dec 2018 15:19:37 +0100 Message-ID: To: "Gao, Liming" Cc: "Kinney, Michael D" , "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH 0/3] fixes for CLANG35 on ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 14:19:50 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 12 Dec 2018 at 15:19, Gao, Liming wrote: > > Make sense. So, CLANG35 tool chain can also be used by CLANG 3.5 and above version compiler, like GCC49? > Exactly > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > > Sent: Wednesday, December 12, 2018 10:03 PM > > To: Gao, Liming > > Cc: Kinney, Michael D ; edk2-devel@lists.01.org; Laszlo Ersek > > Subject: Re: [edk2] [PATCH 0/3] fixes for CLANG35 on ARM > > > > On Wed, 12 Dec 2018 at 15:01, Gao, Liming wrote: > > > > > > Ard: > > > I have no comments on this patch. So, CLANG38 has no issue. If so, could you recommend use CLANG38? > > > > > > > Yes, the latest is always preferred. However, since CLANG38 enables > > LTO, you need the LLVMgold plugin, which is not shipped for all > > versions of Clang by the distros. So it is good to keep CLANG35 as a > > fallback. > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > Sent: Wednesday, December 12, 2018 6:33 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming > > > > ; Feng, Bob C ; Leif Lindholm ; Laszlo Ersek > > > > > > > > Subject: [PATCH 0/3] fixes for CLANG35 on ARM > > > > > > > > Building with Clang 3.5 for ARM may result in build breakage, due to the > > > > fact that it may emit non-adjacent movw/movt instructions pairs which > > > > cannot be relocated in PE/COFF. We pass -mno-movt in some places to > > > > work around a related issue in the relocatable PrePi in ArmVirtPkg, but > > > > we need to disable movw/movt entirely to really address this issue. > > > > > > > > So first, fix some breakage that results from building with -mlong-calls > > > > in the optimized BaseMemoryLib code (#1) > > > > > > > > Patch #2 switches to -mkernel, which disables movw/movt generation (and > > > > enabled -mlong-calls as a side effect) > > > > > > > > Patch #3 removes the now redundant, and incompatible command line > > > > overrides for the relocatable PrePi. > > > > > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Bob Feng > > > > Cc: Leif Lindholm > > > > Cc: Laszlo Ersek > > > > > > > > Ard Biesheuvel (3): > > > > MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations > > > > BaseTools/tools_def ARM CLANG35: work around -mno-movt option name > > > > change > > > > ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option > > > > > > > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ----- > > > > ArmVirtPkg/ArmVirtXen.dsc | 5 ----- > > > > BaseTools/Conf/tools_def.template | 2 +- > > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareGuid.S | 1 + > > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CompareMem.S | 1 + > > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/CopyMem.S | 1 + > > > > MdePkg/Library/BaseMemoryLibOptDxe/Arm/SetMem.S | 5 +++++ > > > > 7 files changed, 9 insertions(+), 11 deletions(-) > > > > > > > > -- > > > > 2.19.2 > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel