Re: [PATCH edk2-platforms v2 3/8] Platform/Overdrive: fix a typo in the DT

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Thu, 28 Nov 2019 at 13:32, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote:
> > DT unit addresses are hex quantities but they should not include
> > the 0x prefix.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> But can you clarify in commit message that this is a cosmetic/style
> change only?
>

Sure.


> (And maybe mirror this cleanup in
> Platform/SoftIron/Overdrive1000Board/FdtBlob/styx-overdrive1000.dts
> ? These appear to be the only two instances in the repo.)
>
> /
>     Leif
>
> > ---
> >  Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> > index 1d8a6caafd82..a92ab695fb2e 100644
> > --- a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> > +++ b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts
> > @@ -291,7 +291,7 @@
> >                       dma-coherent;
> >               };
> >
> > -             ccn@0xe8000000 {
> > +             ccn@e8000000 {
> >                       compatible = "arm,ccn-504";
> >                       reg = <0x0 0xe8000000 0x0 0x1000000>;
> >                       interrupts = <0x0 0x17c 0x4>;
> > --
> > 2.17.1
> >