From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.6347.1574947919645344783 for ; Thu, 28 Nov 2019 05:31:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Y1w1EhXo; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id y23so2886286wma.0 for ; Thu, 28 Nov 2019 05:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=guTEMSvXjEKD3SOqQZfYVPsUiLUdQzP4yz34YUTSjzM=; b=Y1w1EhXoxnwTVkgccZ2qQ7gwDtuVXXQPfddQqheoc2ysnUQsJh6eAXxWTcFoj3VuEq W4vUccodY7hA5gYTX4ymY4klCYWqmEew2aC4NxovWqMs+gyVAuplNAAozpvRb3eAOZjQ tKvfC8wOvnEYt0e0PMj5jynT4Zl5i4RAXxy5cDbKFKAQkZHW47DaO7Ftl6yWgqr3DIqB yu2/WgVI+Q6ZzQ5qvBZ8hVH/Mgi1gf+4IxJQJ6446qWCLCqxOA8PQXo9ZOXwC+dy2R8z eGvdgHTEndD26Yi3wlu6xI+X9KFm972JW71OlktqD1cR38a/+yrXvtlpg1KGEtNIJyiF fh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=guTEMSvXjEKD3SOqQZfYVPsUiLUdQzP4yz34YUTSjzM=; b=ecTTac4XK7Mqj8zcgoAfVDgwEemjqTJHQcwxHYXNM0PSoycBoKgwtrt+f4mR3kMPcc yTg1tVGGWcCpQHNE2GiuH3RBblujDuKLWICXbtQDcOxBOKZptlpIwXVGQwyChuSnJ5dN +qFUWlqXi43v3aQKZmZ+wFM+D8Ol3ElLsuxsDjD/WGLMfpAmYXli7AroKP9ZRmMjPJcv wPvUalj9+x3pv3RLkvTOfYfud9GgVyGe/NhlG8lc+FoFLbYS+0f4vm/AwN5SwFwsNXkB vw7OBgem+UZPkrtiR2p8RYX19DKNRs38TcMmrK2S2oSdr+sYN0Wv1TvrOcNoxjTvjlK7 K/aw== X-Gm-Message-State: APjAAAUnKcZ+a5eul4pK3cikCR4ePycclHPxmp3Jam1+CkGACShOKaAJ zmxD9i8sZjcJckYf18pr59jUSl1LrzQzS8EJHv52A0aSXZ4= X-Google-Smtp-Source: APXvYqwzpKwErxWReCfz8CdbDjK8xla7KNUWBw2myJNSzkek6cMjy7JUonp8ef2qNT+ElJ9Hbk3G96Dcct3BOwoxsDo= X-Received: by 2002:a1c:4c10:: with SMTP id z16mr9041111wmf.136.1574947917852; Thu, 28 Nov 2019 05:31:57 -0800 (PST) MIME-Version: 1.0 References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-4-ard.biesheuvel@linaro.org> <20191128123200.GN7359@bivouac.eciton.net> In-Reply-To: <20191128123200.GN7359@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Thu, 28 Nov 2019 14:32:01 +0100 Message-ID: Subject: Re: [PATCH edk2-platforms v2 3/8] Platform/Overdrive: fix a typo in the DT To: Leif Lindholm Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Thu, 28 Nov 2019 at 13:32, Leif Lindholm wrote: > > On Wed, Nov 27, 2019 at 19:44:34 +0100, Ard Biesheuvel wrote: > > DT unit addresses are hex quantities but they should not include > > the 0x prefix. > > > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > > But can you clarify in commit message that this is a cosmetic/style > change only? > Sure. > (And maybe mirror this cleanup in > Platform/SoftIron/Overdrive1000Board/FdtBlob/styx-overdrive1000.dts > ? These appear to be the only two instances in the repo.) > > / > Leif > > > --- > > Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > > index 1d8a6caafd82..a92ab695fb2e 100644 > > --- a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > > +++ b/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts > > @@ -291,7 +291,7 @@ > > dma-coherent; > > }; > > > > - ccn@0xe8000000 { > > + ccn@e8000000 { > > compatible = "arm,ccn-504"; > > reg = <0x0 0xe8000000 0x0 0x1000000>; > > interrupts = <0x0 0x17c 0x4>; > > -- > > 2.17.1 > >