From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4265A21A16EFF for ; Fri, 19 May 2017 01:32:11 -0700 (PDT) Received: by mail-it0-x233.google.com with SMTP id w68so22817346itc.0 for ; Fri, 19 May 2017 01:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qhNUJQY74He3RRA7po05c8OW5afHyJOGky1xzetq+Yo=; b=OL3VyUGfgM1gMVDbHcIVJIQSDs1MKIIowRnHC/NBPTCO+PrceGkGHlguxLiCTj9YfX abHD4gF3yTNg+/XBuxaCdlCmX9lLV1yvA+Vr7n/8TqdYGikhhbSw/hWDXG11HipJqc+4 oFwe4L45tBVQpX4u67keDwXPLQdGve8DQ4PSU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qhNUJQY74He3RRA7po05c8OW5afHyJOGky1xzetq+Yo=; b=PVApqHCMeXyeuduQRF61w5PxDJRFuIS3F3ykvQDEsik4Z2s+JzVK1wszeR4iT46RG+ h0i5d6gP+AWkr9lTpw2eRfxwdJPPoRxV28jPyU/InwRAVsQd1l8NTedQ7MTqKtJkvMh8 PHtN8Iaqn5/kxZiJTKwZBeH5CUaZDuw9iDXWzF6Ippai3lzs/YEAFz+RG5vP3Q3Yvyc/ XtySFwLDFAi8uN4UKbCYJylEVHbktRDR2BSVSvogoGLdhHdyakvdT13ildVQimflr9hY UpWtzCWef71yUY7kU05ADyiPub4xAN68P5XHKomYKFoLrRMliHzv/2mviX/o56c8LhGh MX6g== X-Gm-Message-State: AODbwcASYl5yWSY9yAijMewgXCCN80TUHuzRKumXGXWDyoOH1OsLy9vm rx1rfdwrU8dFIn+kHtYcY9fe0v2pRjjT X-Received: by 10.36.61.211 with SMTP id n202mr6640346itn.98.1495182730506; Fri, 19 May 2017 01:32:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.164.24 with HTTP; Fri, 19 May 2017 01:32:10 -0700 (PDT) In-Reply-To: <1495175456-4880-1-git-send-email-michael.d.kinney@intel.com> References: <1495175456-4880-1-git-send-email-michael.d.kinney@intel.com> From: Ard Biesheuvel Date: Fri, 19 May 2017 09:32:10 +0100 Message-ID: To: Michael Kinney Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Andrew Fish Subject: Re: [Patch] OvmfPkg: Add XCODE5 statements to fix build break X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 08:32:11 -0000 Content-Type: text/plain; charset="UTF-8" On 19 May 2017 at 07:30, Michael Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=559 > > The XCODE5 tool chain has a FAMILY of GCC. The > GCC statements in the [BuildOptions] section add > flags that are not compatible with XCODE5. Add > empty XCODE5 statements in [BuildOptions] sections > to prevent the use of the GCC flags in XCODE5 > builds. > > Cc: Laszlo Ersek > Cc: Andrew Fish > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael D Kinney Does XCODE not have a way to set the section alignment? This way, the DXE memory protection and OS memory attribute table protection is defeated. Also, does this rely on the order of assignment? > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index bd115c9..a0ea5db 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -75,11 +75,13 @@ > > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > # Force PE/COFF sections to be aligned at 4KB boundaries to support page level > # protection of DXE_SMM_DRIVER/SMM_CORE modules > [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > ################################################################################ > # > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 9727db8..9ab58aa 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -80,11 +80,13 @@ > > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > # Force PE/COFF sections to be aligned at 4KB boundaries to support page level > # protection of DXE_SMM_DRIVER/SMM_CORE modules > [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > ################################################################################ > # > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 61aaed7..88060cd 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -80,11 +80,13 @@ > > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > # Force PE/COFF sections to be aligned at 4KB boundaries to support page level > # protection of DXE_SMM_DRIVER/SMM_CORE modules > [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > + XCODE:*_*_*_DLINK_FLAGS = > > ################################################################################ > # > -- > 2.6.3.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel