Re: [platforms: PATCH v3 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 8 November 2018 at 02:57, Marcin Wojtas <mw@semihalf.com> wrote:
> From: Tomasz Michalec <tm@semihalf.com>
>
> Added fields specific for Xenon host controller and declaration
> of ArmadaBoardDescSdMmcGet function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> index ee8e06e..4bb7a43 100644
> --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
> @@ -14,6 +14,8 @@
>  #ifndef __ARMADA_BOARD_DESC_LIB_H__
>  #define __ARMADA_BOARD_DESC_LIB_H__
>
> +#include <Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h>
> +

I don't like this at all. We are depending on an internal header of a
certain implementation. Please find a better way to share these
definitions.

>  #include <Library/ArmadaSoCDescLib.h>
>
>  //
> @@ -57,7 +59,12 @@ typedef struct {
>  //
>  typedef struct {
>    MV_SOC_SDMMC_DESC *SoC;
> -  UINTN              SdMmcDevCount;
> +  UINTN    SdMmcDevCount;
> +  BOOLEAN  Xenon1v8Enabled;
> +  BOOLEAN  Xenon8BitBusEnabled;
> +  BOOLEAN  XenonSlowModeEnabled;
> +  UINT8    XenonTuningStepDivisor;
> +  EFI_SD_MMC_SLOT_TYPE SlotType;
>  } MV_BOARD_SDMMC_DESC;
>
>  //
> @@ -84,4 +91,12 @@ typedef struct {
>    UINTN             UtmiDevCount;
>    UINTN             UtmiPortType;
>  } MV_BOARD_UTMI_DESC;
> +
> +EFI_STATUS
> +EFIAPI
> +ArmadaBoardDescSdMmcGet (
> +  IN OUT UINTN               *SdMmcDevCount,
> +  IN OUT MV_BOARD_SDMMC_DESC **SdMmcDesc
> +  );
> +
>  #endif /* __ARMADA_SOC_DESC_LIB_H__ */
> --
> 2.7.4
>