From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2AFDA2118D953 for ; Thu, 8 Nov 2018 03:47:37 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id c6-v6so14354787iob.11 for ; Thu, 08 Nov 2018 03:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hw7UR2PGluOuaprjvAJ55QRQ9rJIGTY0aZ3OznfTmLw=; b=k3o1FGowYBnXG+TvJyefeRN9YUpPaSfDhDHuWVvB+maJtSXAC2KYU1pPsWp267klmg xcucr1zTcf1S2lQBKZzuTsFnu4W2YwM083yN3SYvnRaur29CjE7NELY1QrEoANB79WsG LRpzUhMDSoJgBe8qwxyncIZGODxzY5H30cCAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hw7UR2PGluOuaprjvAJ55QRQ9rJIGTY0aZ3OznfTmLw=; b=dloWyr0Ge/JdcIEvRXDZvRPOFfZXGeQfPocmRz/ILz/ZOxv65j3shz6108DJHvTd+Q 1hGmr3vXp5YrMnf93cUv7x07Z+ybfLpsXzR9P6+Ux4FGbNMftQC+5ZPsXHzTwYiPmtrU bd4o2hAYE9G73u64rk7iRhjk020SSqOS6Zon7rAvr9OJrOsPJY9TJ5mqNUwdNg9qQz4z +kJBrgxsJQ7EbWU6hIwEAdNDOZroaycqwzfHOmsNq2glvdpo71HiPbWroY3J/JfgyCL5 hkZlpRjiZBCJLWk5hQ3ynPFcRA8Jr9XFZ+RbJgzZ2p84gZMwEarEjEhTfJvU5JlaNvht IU5A== X-Gm-Message-State: AGRZ1gKiteoLWE8EaNjxfeTSzjS4GjZvTXJHBr4OGm7H5ejTPaGBajeh OcE12AN+RKfQ1BmJptweEsg5LdVAf6BJQQ/u7KME9A== X-Google-Smtp-Source: AJdET5c4BvenncKb3Ywq2VmN+d6ELKr4D1CTL2K5Fjhg6FnCjkGCnhNgT9QM6r7suapRzV8iTefFrZFOW4I9OhF6FeA= X-Received: by 2002:a6b:3707:: with SMTP id e7-v6mr3529868ioa.60.1541677656000; Thu, 08 Nov 2018 03:47:36 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a6b:4f16:0:0:0:0:0 with HTTP; Thu, 8 Nov 2018 03:47:35 -0800 (PST) In-Reply-To: <1541642266-15643-3-git-send-email-mw@semihalf.com> References: <1541642266-15643-1-git-send-email-mw@semihalf.com> <1541642266-15643-3-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Thu, 8 Nov 2018 12:47:35 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Wu, Hao A" , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Tomasz Michalec Subject: Re: [platforms: PATCH v3 2/7] Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 11:47:37 -0000 Content-Type: text/plain; charset="UTF-8" On 8 November 2018 at 02:57, Marcin Wojtas wrote: > From: Tomasz Michalec > > Added fields specific for Xenon host controller and declaration > of ArmadaBoardDescSdMmcGet function. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > index ee8e06e..4bb7a43 100644 > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > @@ -14,6 +14,8 @@ > #ifndef __ARMADA_BOARD_DESC_LIB_H__ > #define __ARMADA_BOARD_DESC_LIB_H__ > > +#include > + I don't like this at all. We are depending on an internal header of a certain implementation. Please find a better way to share these definitions. > #include > > // > @@ -57,7 +59,12 @@ typedef struct { > // > typedef struct { > MV_SOC_SDMMC_DESC *SoC; > - UINTN SdMmcDevCount; > + UINTN SdMmcDevCount; > + BOOLEAN Xenon1v8Enabled; > + BOOLEAN Xenon8BitBusEnabled; > + BOOLEAN XenonSlowModeEnabled; > + UINT8 XenonTuningStepDivisor; > + EFI_SD_MMC_SLOT_TYPE SlotType; > } MV_BOARD_SDMMC_DESC; > > // > @@ -84,4 +91,12 @@ typedef struct { > UINTN UtmiDevCount; > UINTN UtmiPortType; > } MV_BOARD_UTMI_DESC; > + > +EFI_STATUS > +EFIAPI > +ArmadaBoardDescSdMmcGet ( > + IN OUT UINTN *SdMmcDevCount, > + IN OUT MV_BOARD_SDMMC_DESC **SdMmcDesc > + ); > + > #endif /* __ARMADA_SOC_DESC_LIB_H__ */ > -- > 2.7.4 >