From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 33DBA21124B07 for ; Fri, 7 Sep 2018 04:04:56 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id v14-v6so1207965iob.4 for ; Fri, 07 Sep 2018 04:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sjpDaxn5BTB50ylTYjWTZDrYoBASa/HDOcom3Li3GYs=; b=TPgp+NKt+D5VPrkIMFuj3IH2KmWOz+1q1keSjPGgzvjfHwuR2xFTpzmt/XsjtR7gam VzEXAlwXNwWrU3/S9pIaleowMdW+yYSG45v3fvoyz05TLcBIc9ZV2RbxQ1+QjI62dEFQ 0PjP3OVlnUHmPKHQV+0WZIpUgPUwWm1KbP0f4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sjpDaxn5BTB50ylTYjWTZDrYoBASa/HDOcom3Li3GYs=; b=t331D2/ReJjgqiD9fXm0g9IKc3pV6Zt6Hlh3YxZuUiwOAyoOlWRQWbOqa7dltdcrYX vAnGSA64lPRY83J9VJ829asQtCKmc/ebYtL7Vk1pGalrKfJHvgrnp7BmDtgiD/QS/S4B p+yQGUb45lRUhuG79gDadQlzow3D+h68UhxzLBCY91Q8PAWJJt8hu/Mx7J3qC3yx5OXO xrU3MLEULEnAPpty0grd15B3wjWyAV+f2Tcfuv551pU4YaQjcD15AijalMUZn839xOTK 9/zhDpbMf4ztwk+shrXF7oWRZEP/zzyRq0mGr1LDMG+GeIM9SQpDas+wGEv86n1kLb2S Vluw== X-Gm-Message-State: APzg51AlzoPhKP1M6jaDx0zVKQzIGVbd8hyVCkeHa8Y+mGQ/681xcVRe ywxy5T+AN61sIgiwh3lldxtu2iV+CWjpbW2J8UjtbQ== X-Google-Smtp-Source: ANB0VdbZME7GrR8arK0Kzadozx2h3unJMIX+N2h1akriKEgkYvzcflUYEqGwF2AWJKFmM3FPXTbracVp89OO1yxq1nY= X-Received: by 2002:a6b:be83:: with SMTP id o125-v6mr5476060iof.173.1536318296174; Fri, 07 Sep 2018 04:04:56 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:1c06:0:0:0:0:0 with HTTP; Fri, 7 Sep 2018 04:04:55 -0700 (PDT) In-Reply-To: <1536311416-2751-1-git-send-email-mw@semihalf.com> References: <1536311416-2751-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 7 Sep 2018 13:04:55 +0200 Message-ID: To: Marcin Wojtas , "Wu, Hao A" Cc: "edk2-devel@lists.01.org" , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Tomasz Michalec Subject: Re: [PATCH v2 0/4] SdMmc fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 11:04:57 -0000 Content-Type: text/plain; charset="UTF-8" +Hao On 7 September 2018 at 11:10, Marcin Wojtas wrote: > Hi, > > Answering the review request, I extracted SdMmcPciHcDxe driver fixes > from SdMmcOverride protocol modification. Comparing to v1, > patches are rebased onto the newest master branch and also a macro > is used instead of the raw value in SdMmcHcReset. > > Patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-fixes-r20180907 > > I'm looking forward to the comments and remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2 > * rebase on top of the newest master > * resolve conflicts after taking fixes out from new features > * 3/4 - use macro instead of raw value in SdMmcHcReset > > Marcin Wojtas (3): > MdeModulePkg/SdMmcPciHcDxe: Fix HS200 operation > MdeModulePkg/SdMmcPciHcDxe: Adjust eMMC clock and bus width sequence > MdeModulePkg/SdMmcPciHcDxe: Execute card detect only for RemovableSlot > > Tomasz Michalec (1): > MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 10 +++++ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 39 +++++--------------- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 ++++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 +-- > 4 files changed, 34 insertions(+), 39 deletions(-) > > -- > 2.7.4 >