From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=PuuSHRRS;
 spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193])
 by groups.io with SMTP; Fri, 17 May 2019 08:28:07 -0700
Received: by mail-it1-f193.google.com with SMTP id e184so12672091ite.1
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:28:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=tlwN6SjeVK36MPpVmaFDCHqID2tyHF96k41DFd4g5sk=;
        b=PuuSHRRSt1zhztKd8PaxocDf13ti60WobbUaJfyh8x6oc7bqzT9RE5XoXwwDrZzWZ5
         1zqISYLNyhoVqVIVMQR6IGjICdFjfjJbh2wJVHAl8miXct6bqd7R9IWvoh0Oceqq810c
         SYekGR3HsGjBTIyUr0691e7DH2tTYoNmg4qaoLK3UEQQOdkSPKC54KVTCdGZaxKSWhpw
         2+XsqevkzQgpnZHTYUt7Hb+WtSs5Lnf8YIpCW8v1cwxUFDmeM0frVH/IxREKzcpBNZ5F
         5TxIZ8FBdfp6Uy7DYSH56VuX7SRCWPXMmOeusOMJTsZRYmJgbA2OWDXbxw9xuAgajI8P
         3/GA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=tlwN6SjeVK36MPpVmaFDCHqID2tyHF96k41DFd4g5sk=;
        b=TknT1xyO8qi6qkWKCdoFgasCjEpZ8k6dAQtFwAMiwjQCCNNIkBtZBniYXJQD6GaEY5
         PAMlApPOaG3NoMcnssucunoWG2kdzTqdCHFS7CaEfq8nDSFZCJ8GiGIz+OpE04MN+hIg
         1/3i7MpqA5UKDwuW2xK++9PVQu3oAc6HTSu7Zne9TQA1+fa0aHMqsrrTMrcVccuO3CIP
         nP3BjnEZ0+UdiYTGkjuxXdJWFSvbexiFVUoKB6iGRlyR2JbxwpE3H3MddqAqGq+LbjrG
         A3drY+FhWTagM5D+t6AWoIxM0rv/yuTOlcc5M0usClqIjG6sbMKXak6ZPNdGWr22NRg/
         aCmw==
X-Gm-Message-State: APjAAAUWbzpSImpq7GlXpq4CC1PWuLTSoXZmuV50R7yvA4fKJ6Mk+TVV
	9kdS7SRvC08kCZ7SvBc3SDZuSWgbip3o6nxxmOvDFEWWrnEE0w==
X-Google-Smtp-Source: APXvYqwgtG5rZuFwmjSq77gMFbcKz04WFg69jf3VJd4EUTef8QkQlPVY/BzSoyQvOht+ZTXKuADicddh0J/ZZIFdlI4=
X-Received: by 2002:a24:ca84:: with SMTP id k126mr183996itg.104.1558106886592;
 Fri, 17 May 2019 08:28:06 -0700 (PDT)
MIME-Version: 1.0
References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-8-hao.a.wu@intel.com>
In-Reply-To: <20190514020831.7728-8-hao.a.wu@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:27:54 +0200
Message-ID: <CAKv+Gu-TdByJxLxzvxtNxR=8fhke_WMXx0MgFUSBrw69T2wT6g@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 05/16] Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib
To: edk2-devel-groups-io <devel@edk2.groups.io>, "Wu, Hao A" <hao.a.wu@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>, Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2019 at 04:08, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
>
> Hisilicon platforms have already switched to the BDS driver in
> MdeModulePkg by commit 5845a5cde9d6bd51d77067b2594654005887a434.
>
> Thus, the consume of GenericBdsLib and PlatformBdsLib is no longer needed.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/D03.dsc | 2 --
>  Platform/Hisilicon/D05/D05.dsc | 2 --
>  Platform/Hisilicon/D06/D06.dsc | 1 -
>  3 files changed, 5 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index 066cace45b..7e8cb59641 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -65,8 +65,6 @@
>    OemAddressMapLib|Platform/Hisilicon/D03/Library/OemAddressMap2P/OemAddressMap2PHi1610.inf
>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.inf
>
> -  GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
> -  PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
>    BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>    BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
> index d5b723ed40..1d3a054d29 100644
> --- a/Platform/Hisilicon/D05/D05.dsc
> +++ b/Platform/Hisilicon/D05/D05.dsc
> @@ -79,8 +79,6 @@
>    OemAddressMapLib|Platform/Hisilicon/D05/Library/OemAddressMapD05/OemAddressMapD05.inf
>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.inf
>
> -  GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
> -  PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
>    BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
> index 73bea728b0..c1cd13b6c7 100644
> --- a/Platform/Hisilicon/D06/D06.dsc
> +++ b/Platform/Hisilicon/D06/D06.dsc
> @@ -70,7 +70,6 @@
>    PlatformSysCtrlLib|Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.inf
>
>    CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> -  GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
>    BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> --
> 2.12.0.windows.1
>
>
> 
>