From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B08F222198F6C for ; Sat, 23 Dec 2017 05:32:02 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id e204so27172062iof.12 for ; Sat, 23 Dec 2017 05:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AWCah1Gs7voq73ZItj79vqEctvl/EVUm7QzyLQXOLl8=; b=U8reQ8xHGxyHAGGQOHNNv++8K4MJo0Um2W8OuO7vV5ph/vMphNDkfMqaXQFH617KYr tlRgXtemILpFUTqBpHFpsZvdo9GY9VpdsjggVprizXjhqZ6NAfVrO+f447DPo1hBCJ4+ OgpUfu1Bi+hDlWI2ichjXM2xdGxyeOAGzMuXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AWCah1Gs7voq73ZItj79vqEctvl/EVUm7QzyLQXOLl8=; b=h4uGMIV5XuXVmY0cHqPe3aJPEF4c1kcAQyVjVnNnecWzb5YSmN1L8gcrD4OwxPGc/y w1jZMDJKI3Ga2jCqrPf5WMlRu69A7/EaPSfjugs8jG3v8VOGnnTtmtnA7cWnuxi9XO/t fJ88fNaKw05ZyQe6BFAYMLoveMDVhhVzKdMeXA6drhdNuiPuNHEjWBEOxbnO823LoUum yPQ/HffKuG69OTo7xhLiSGHOf3hj5MsWZKbMxsTSp9hqFbIFiMYfeFytAJiAtq6mOgQM tSF2ukA7EdqllL210WXFjCGd6kZ4p6eVsfz9OXpjLQ3HNoEeNIe0ST0Y6RdcLLWgZqrd 1DCA== X-Gm-Message-State: AKGB3mLZl/SKNn7kBjJGs8uDB95ZoR4CNE+tuHc37vGLczDvPFAAVD8x vjzxlndDSsbcZ3MuVIpjq3Wm/oxnYfE4mTcTECQ/BufB X-Google-Smtp-Source: ACJfBovuEA6jiNEKIkCXdRsWELEDL5ad6Dx2vuORPiRxVc+8Nb7TBI+PjaL2sttNTsAQ/V3o22nIM6UGOfKyPTKmHOU= X-Received: by 10.107.133.34 with SMTP id h34mr21834500iod.253.1514036213249; Sat, 23 Dec 2017 05:36:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 05:36:52 -0800 (PST) In-Reply-To: <20171222183418.8616-12-evan.lloyd@arm.com> References: <20171222183418.8616-1-evan.lloyd@arm.com> <20171222183418.8616-12-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 13:36:52 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH v2 11/13] ArmPlatformPkg: Reserving framebuffer at build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 13:32:03 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 18:34, wrote: > From: Girish Pathak > > Currently framebuffer memory is either reserved in special VRAM or > dynamically allocated using boot services memory allocation functions. > When allocated using boot services calls the memory has to be allocated > as EfiBootServicesData. Unfortunately failures have been seen with this > case. There is also an unfortunate lack of control on the placement of > the framebuffer. > > This change introduces two PCDs, PcdArmLcdFrameBufferBase and > PcdArmLcdFrameBufferSize which enable build time reservation of the > framebuffer, avoiding the need to allocate dynamically. This allows > the framebuffer to appear as "I/O memory" outside of the normal RAM > map, which is similar to the "VRAM" case. > > This change has no impact on current code, only enables the option > of build time reservation of framebuffers. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmPlatformPkg.dec | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec > index 9a61e4a511024c80e787500de5038779363f0d95..a887ffcfd9f3b168bfb19ff0a84e310c7891b527 100644 > --- a/ArmPlatformPkg/ArmPlatformPkg.dec > +++ b/ArmPlatformPkg/ArmPlatformPkg.dec > @@ -93,6 +93,10 @@ [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdPL111LcdBase|0x0|UINT32|0x00000026 > gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x0|UINT32|0x00000027 > > + ## If set, frame buffer memory will be reserved and mapped in the system RAM > + gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferSize|0x0|UINT32|0x00000043 > + gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferBase|0x0|UINT64|0x00000044 > + If these are only used in the VExpress edk2-platforms code, could you please move them there instead? Thanks. > ## PL180 MCI > gArmPlatformTokenSpaceGuid.PcdPL180SysMciRegAddress|0x00000000|UINT32|0x00000028 > gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x00000000|UINT32|0x00000029 > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >