From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jeremy Linton <jeremy.linton@arm.com>,
"Gao, Liming" <liming.gao@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Steve Capper <steve.capper@arm.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ryan Harkin <ryan.harkin@linaro.org>,
linaro-uefi <linaro-uefi@lists.linaro.org>
Subject: Re: [PATCH 1/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro
Date: Tue, 15 Nov 2016 07:38:31 +0000 [thread overview]
Message-ID: <CAKv+Gu-WVhYwAiVJwQddJBD20yd3g+icz6jGyuW6ASot4ncHsQ@mail.gmail.com> (raw)
In-Reply-To: <1479157789-14674-2-git-send-email-jeremy.linton@arm.com>
(+ Liming)
On 14 November 2016 at 21:09, Jeremy Linton <jeremy.linton@arm.com> wrote:
> Add some definitions to mask the sense key from sense data,
> and check the validity of the returned sense data.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
> MdePkg/Include/IndustryStandard/Scsi.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Scsi.h b/MdePkg/Include/IndustryStandard/Scsi.h
> index 0d81314..802479e 100644
> --- a/MdePkg/Include/IndustryStandard/Scsi.h
> +++ b/MdePkg/Include/IndustryStandard/Scsi.h
> @@ -369,6 +369,8 @@ typedef struct {
> //
> // Sense Key
> //
> +#define EFI_SCSI_REQUEST_SENSE_ERROR (0x70)
> +#define EFI_SCSI_SK_VALUE(byte) (byte&0x0F)
If you fix the white space
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> #define EFI_SCSI_SK_NO_SENSE (0x0)
> #define EFI_SCSI_SK_RECOVERY_ERROR (0x1)
> #define EFI_SCSI_SK_NOT_READY (0x2)
> --
> 2.5.5
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-11-15 7:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 [PATCH 0/8] ATAPI support on SiI SATA adapter Jeremy Linton
2016-11-14 21:09 ` [PATCH 1/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro Jeremy Linton
2016-11-15 7:38 ` Ard Biesheuvel [this message]
2016-11-15 10:51 ` Gao, Liming
2016-11-14 21:09 ` [PATCH 2/7] EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks Jeremy Linton
2016-11-15 16:04 ` Ard Biesheuvel
2016-11-14 21:09 ` [PATCH 3/7] EmbeddedPkg: SiI3132: Add SCSI protocol support to header Jeremy Linton
2016-11-14 21:24 ` Jeremy Linton
2016-11-15 17:02 ` Ard Biesheuvel
2016-11-16 15:44 ` Ryan Harkin
2016-11-14 21:09 ` [PATCH 4/7] EmbeddedPkg: SiI3132: Break out FIS command submission Jeremy Linton
2016-11-15 17:10 ` Ard Biesheuvel
2016-11-14 21:09 ` [PATCH 5/7] EmbeddedPkg: SiI3132: Cleanup device node creation Jeremy Linton
2016-11-14 21:09 ` [PATCH 6/7] EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol Jeremy Linton
2016-11-14 21:09 ` [PATCH 7/7] EmbeddedPkg: SiI3132: Correct the IoAlign Jeremy Linton
2016-11-14 21:09 ` [PATCH] Platforms/ARM/Juno: Add SCSI pass-through protocol Jeremy Linton
2016-11-15 7:43 ` [PATCH 0/8] ATAPI support on SiI SATA adapter Ard Biesheuvel
2016-11-15 14:54 ` Jeremy Linton
2016-11-15 14:57 ` Ard Biesheuvel
2016-11-15 15:05 ` Jeremy Linton
2016-11-15 15:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-WVhYwAiVJwQddJBD20yd3g+icz6jGyuW6ASot4ncHsQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox