From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E647981E53 for ; Mon, 14 Nov 2016 23:38:28 -0800 (PST) Received: by mail-it0-x22b.google.com with SMTP id b123so81191844itb.0 for ; Mon, 14 Nov 2016 23:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=K2RjP5dqLCfZ7DHqsPHl5cBJb7zuokxxFyxdmoPE33M=; b=U/8exV/vhOH3VWeCXb3mm1K8ttPVChY0mjaozwQPVXo3FqAFu7949r3tudfJ0qcai+ ZUcO29UIYSbEdJ7Si9QU4z2+1B/lkXaX+G/6zGRdwn0w2ll0Tamqq8vBXSkuM8yCeSdB UhRkuVxTXKga4tkDBvqhCKP5MgOpyjx+JhWqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=K2RjP5dqLCfZ7DHqsPHl5cBJb7zuokxxFyxdmoPE33M=; b=dtq6Xra2cV/RigOvVJfA8zIJtyNKcD0t0eGcXFmzFFvifCQ4uzQ2SpenwSPYIxvQa4 ER56DZ3gxHCCr4smIbqY1mIAMqAYEdQHPGmEo4wfhX+YX9jEjsqIxSyuvOYpjkQC+kE9 o2Qiqar/QJoRPve4TqqXUsoKYSDsMKBVyphDoEVbc9+r0TIbCl77ckFIjjBxa32//PfI WVRlKzdWrF/XuEmXVxF4p9IG2AEW56LQeqJuUJ2zi/CfGSo4YsWdSroSBI6IZdn1MiqL YXYi7W+jYew1BsuimkqQm0mMcagxY/9qSmeXRi+Lt/g0sj87MCYpNvRthhV2EbOT58GT 588w== X-Gm-Message-State: ABUngveqKTc3p8seVlrrx2xnY+ywuFl6WTnEDva59iQMmlDQ0hmayIF60aFw+yWGlaeb06VVTMYLK/I9m/wywbb0 X-Received: by 10.36.83.80 with SMTP id n77mr1667822itb.63.1479195512344; Mon, 14 Nov 2016 23:38:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Mon, 14 Nov 2016 23:38:31 -0800 (PST) In-Reply-To: <1479157789-14674-2-git-send-email-jeremy.linton@arm.com> References: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> <1479157789-14674-2-git-send-email-jeremy.linton@arm.com> From: Ard Biesheuvel Date: Tue, 15 Nov 2016 07:38:31 +0000 Message-ID: To: Jeremy Linton , "Gao, Liming" Cc: edk2-devel-01 , Steve Capper , Leif Lindholm , Ryan Harkin , linaro-uefi Subject: Re: [PATCH 1/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 07:38:29 -0000 Content-Type: text/plain; charset=UTF-8 (+ Liming) On 14 November 2016 at 21:09, Jeremy Linton wrote: > Add some definitions to mask the sense key from sense data, > and check the validity of the returned sense data. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeremy Linton > --- > MdePkg/Include/IndustryStandard/Scsi.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Scsi.h b/MdePkg/Include/IndustryStandard/Scsi.h > index 0d81314..802479e 100644 > --- a/MdePkg/Include/IndustryStandard/Scsi.h > +++ b/MdePkg/Include/IndustryStandard/Scsi.h > @@ -369,6 +369,8 @@ typedef struct { > // > // Sense Key > // > +#define EFI_SCSI_REQUEST_SENSE_ERROR (0x70) > +#define EFI_SCSI_SK_VALUE(byte) (byte&0x0F) If you fix the white space Acked-by: Ard Biesheuvel > #define EFI_SCSI_SK_NO_SENSE (0x0) > #define EFI_SCSI_SK_RECOVERY_ERROR (0x1) > #define EFI_SCSI_SK_NOT_READY (0x2) > -- > 2.5.5 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel