From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7193621FCA272 for ; Wed, 1 Nov 2017 08:14:57 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id 189so6740626iow.10 for ; Wed, 01 Nov 2017 08:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bUfVMDO5WCPtWiuAtz+O5eEBj+2tSMmARfBndhKKEgk=; b=J2GX+YvqK1nFzMYaYBHOFE5WbRk4v93sLo8bR7HbuFGll0Moluj+9lNBGn6UTWTx1l RfLsLGYFL+PpQxOffGIydvsmW76dc1QsMvradfwfge4xq/xoD+HjDinIVyCD8X4jeNe+ Jg1qVL3Yb6Pn2YXPubQSTUvejWwhSSjWTilzs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bUfVMDO5WCPtWiuAtz+O5eEBj+2tSMmARfBndhKKEgk=; b=bkD8oLSW7tLBW9NWLeBA0BqpuiJ4RvKF7iLiO2akAqo1nixZT5Ix4aY3ADqNSTPChQ gy+kdwHAZKY/2b7jjGzlfLRX5le33Tb1AG/cqW3VPxqUvL2M8W+CcZMtUfCLdOD8MFYI 6N32WbduNdKl6obSbdRATjB7LOM/86QWuQ4ouJSE8Zo4POGJb7agD7SXmWptiHKmtjpt g4TB3BDulCMkwOAQQ5jXyhMtkbIFay9m2BCTEX0xP6cFvDcU93GXBj71EQUPtCDFQlRU BzgVDMRGqwNddfGpztMVVlPnzMngGMkfnwhwdh9kM9UwFT14QRDAC8E443maKWhnkcsa bTNQ== X-Gm-Message-State: AMCzsaX8aeLR6Q4X1XCcp4kamOFAqkDBJ/TyIPBEGrLg0moOJzLa4Y2l rCD/jPQ70wU9CkjtAlDOORkkniBKidZGCg7EaNXofvcgjLU= X-Google-Smtp-Source: ABhQp+RBh6EVoOAAA7/hY7zGwZCc3NvG6j6CKBt7SnJKjV7K16sf6FIbjMaM09Y2/myhUnszDlIs+GCyvjdUbNbUa44= X-Received: by 10.36.233.133 with SMTP id f127mr977432ith.34.1509549529656; Wed, 01 Nov 2017 08:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Wed, 1 Nov 2017 08:18:49 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E176A26@SHSMSX104.ccr.corp.intel.com> References: <20171101150125.13679-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E176A26@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 1 Nov 2017 15:18:49 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" , "daniel.thompson@linaro.org" Subject: Re: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 15:14:57 -0000 Content-Type: text/plain; charset="UTF-8" On 1 November 2017 at 15:13, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks - pushed as 3380a591232de2ab3007ab051010a67c3d000d1c >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Wednesday, November 1, 2017 11:01 PM >> To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; Gao, Liming ; Zhu, Yonghong >> >> Cc: daniel.thompson@linaro.org; Ard Biesheuvel >> Subject: [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources >> >> Commit 1894a7c64c0a ("BaseTools/tools_def AARCH64 ARM: disable PIE >> linking") works around an issue that was caught due to the fact that >> PIE linking produces broken .acpi files. However, v2 of that fix >> inadvertently only applied the workaround to the normal linker command >> line, and not to the ASLD one, so the issue still persists. >> >> So add the missing -no-pie options for ASLD on ARM and AARCH64. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> BaseTools/Conf/tools_def.template | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >> index 98df0ffc9294..aebd7d558633 100755 >> --- a/BaseTools/Conf/tools_def.template >> +++ b/BaseTools/Conf/tools_def.template >> @@ -4498,8 +4498,8 @@ DEFINE GCC5_ARM_DLINK_FLAGS = DEF(GCC49_ARM_DLINK_FLAGS) -no-pie >> DEFINE GCC5_ARM_DLINK2_FLAGS = DEF(GCC49_ARM_DLINK2_FLAGS) -Wno-error >> DEFINE GCC5_AARCH64_DLINK_FLAGS = DEF(GCC49_AARCH64_DLINK_FLAGS) -no-pie >> DEFINE GCC5_AARCH64_DLINK2_FLAGS = DEF(GCC49_AARCH64_DLINK2_FLAGS) -Wno-error >> -DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) >> -DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) >> +DEFINE GCC5_ARM_ASLDLINK_FLAGS = DEF(GCC49_ARM_ASLDLINK_FLAGS) -no-pie >> +DEFINE GCC5_AARCH64_ASLDLINK_FLAGS = DEF(GCC49_AARCH64_ASLDLINK_FLAGS) -no-pie >> >> #################################################################################### >> # >> -- >> 2.11.0 >