From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Moorthy Baskaravenkatraman Sambamoorthy
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Kalyan Kumar Nagabhirava
<kalyankumar.nagabhirava@lnttechservices.com>
Subject: Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe
Date: Fri, 1 Jun 2018 14:15:51 +0200 [thread overview]
Message-ID: <CAKv+Gu-XLYzPYwvYZYqoOO9xRmiLp5+f+EwRb0frVqcuuPsVvA@mail.gmail.com> (raw)
In-Reply-To: <CADvd5eyikqTDC_U1q3v2OmMFMx6UK2dh0UKNfDzywjKf7HZJaQ@mail.gmail.com>
On 1 June 2018 at 14:14, Moorthy Baskaravenkatraman Sambamoorthy
<moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
> Hi Ard,
>
> RDK package Secure boot and DRI application for QEMU platform were
> up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same for
> further maintenance.
>
That is fine. But that does *not* allow you to add my reviewed-by
under a patch that I have never seen in my life.
> On 1 June 2018 at 17:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>
>> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman
>> <moorthy.baskaravenkatraman-sambamoorthy@linaro.org> wrote:
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Moorthy Baskaravenkatraman
>> > <moorthy.baskaravenkatraman-sambamoorthy@linaro.org>
>> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Excuse me? I don't remember reviewing these changes.
>>
>> > ---
>> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++-
>> > 1 file changed, 7 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > b/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > index 45feeec8764b..1301c5555efe 100644
>> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
>> > @@ -251,6 +251,7 @@ [Components.common]
>> > MdeModulePkg/Core/Dxe/DxeMain.inf {
>> > <LibraryClasses>
>> >
>> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
>> > +
>> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>> > }
>> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {
>> > <LibraryClasses>
>> > @@ -265,6 +266,7 @@ [Components.common]
>> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
>> > <LibraryClasses>
>> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
>> > +
>> > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf
>> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash
>> > region
>> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>> > }
>> > @@ -326,7 +328,11 @@ [Components.common]
>> > #
>> > # Bds
>> > #
>> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {
>> > + <LibraryClasses>
>> > +
>> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>> > + }
>> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
>> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
>> >
>> > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
>> > --
>> > 2.17.0
>> >
>> > _______________________________________________
>> > edk2-devel mailing list
>> > edk2-devel@lists.01.org
>> > https://lists.01.org/mailman/listinfo/edk2-devel
>
>
>
>
> --
> Regards,
> Moorthy
next prev parent reply other threads:[~2018-06-01 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 11:03 [PATCH 0/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu Moorthy Baskaravenkatraman
2018-06-01 11:03 ` [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe Moorthy Baskaravenkatraman
2018-06-01 12:04 ` Ard Biesheuvel
2018-06-01 12:14 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:15 ` Ard Biesheuvel [this message]
2018-06-01 12:34 ` Moorthy Baskaravenkatraman Sambamoorthy
2018-06-01 12:35 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-XLYzPYwvYZYqoOO9xRmiLp5+f+EwRb0frVqcuuPsVvA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox