From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2AFEA207DF2AD for ; Fri, 1 Jun 2018 05:15:53 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id e20-v6so29421518iof.4 for ; Fri, 01 Jun 2018 05:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZWuvyWmZSW2VoSpy7vVCnyeQkBjuAvfRmMKr72dyx9I=; b=AtOIVuPZvPOeljf+CP9FEcm06rQBy/DFNuQ8wLysTtOkrtql3E5GkeCxS26a1hIrZJ EsQK6sS6W8FaTjj5BCP/kHbRazLEITJp9gUR6GELrSebEdGCZLM7/NtKlSsZ573+XTzZ 3NCZu5Txv6arcMgPrA5loawjLsjtz1UFhLEfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZWuvyWmZSW2VoSpy7vVCnyeQkBjuAvfRmMKr72dyx9I=; b=aSX7AUzdaEdqcpt+biGF4RMl4SuajfuyYd6ZtLt6HsqElik7Du6oWfwWgPMDoEAHto O4ebS+At6LqAGxgjF6zdfhdDmJZB8NgXkS2uSDdRGYvWFG9+EMWXBcSb1HWeL9xTjxAq vHZyaCXEZubcyWc6x/+u7GYadKdG73/4A3KRDw5x9br4BIXdWDJ+mEg8rLzapym9I9cj yswlqVY0HFeKwUVIymGkEI5JeBVBScZTdmMlig4RU3ImdI6/tpHdWWHrzoJIDkpHDDru d7PXZme9RTw6ZbpTKlSGhH+vddSNx0JReu4SW5FTumg+YjoesdpymLqqpeEzy4XG0KKc o7rA== X-Gm-Message-State: APt69E16RfsxYuLRKR8T7/BAkKC6vgCEWYiKLtWW9kNmWZ0etEwiJMiF 60J2gNnxcKOMV1DQWjwe74hridhfpj43l58e4zN3vw== X-Google-Smtp-Source: ADUXVKLMBLmFyFHPPVEluuO5DRu/Q0+JP7iKrtGensCtY5B0+JEE7gTMzprJng+Go8rZ2th/5eDfBSxwWSR8n1Niauo= X-Received: by 2002:a6b:978e:: with SMTP id z136-v6mr10831120iod.60.1527855352413; Fri, 01 Jun 2018 05:15:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 05:15:51 -0700 (PDT) In-Reply-To: References: From: Ard Biesheuvel Date: Fri, 1 Jun 2018 14:15:51 +0200 Message-ID: To: Moorthy Baskaravenkatraman Sambamoorthy Cc: "edk2-devel@lists.01.org" , Kalyan Kumar Nagabhirava Subject: Re: [PATCH 1/1] Platform/Comcast: EDK2 dependencies resolved for RDK Qemu platform * DevicePathLib library class added in DxeMain * NvVarStoreFormattedLib added in VariableRuntimeDxe * DevicePathLib and PcdLib library classes added in DevicePathExe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 12:15:53 -0000 Content-Type: text/plain; charset="UTF-8" On 1 June 2018 at 14:14, Moorthy Baskaravenkatraman Sambamoorthy wrote: > Hi Ard, > > RDK package Secure boot and DRI application for QEMU platform were > up-streamed by Kalyan under edk2-platforms. Now, I'm continuing the same for > further maintenance. > That is fine. But that does *not* allow you to add my reviewed-by under a patch that I have never seen in my life. > On 1 June 2018 at 17:34, Ard Biesheuvel wrote: >> >> On 1 June 2018 at 13:03, Moorthy Baskaravenkatraman >> wrote: >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Moorthy Baskaravenkatraman >> > >> > Reviewed-by: Ard Biesheuvel >> >> Excuse me? I don't remember reviewing these changes. >> >> > --- >> > Platform/Comcast/RDKQemu/RDKQemu.dsc | 8 +++++++- >> > 1 file changed, 7 insertions(+), 1 deletion(-) >> > >> > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc >> > b/Platform/Comcast/RDKQemu/RDKQemu.dsc >> > index 45feeec8764b..1301c5555efe 100644 >> > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc >> > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc >> > @@ -251,6 +251,7 @@ [Components.common] >> > MdeModulePkg/Core/Dxe/DxeMain.inf { >> > >> > >> > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf >> > + >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> > } >> > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf { >> > >> > @@ -265,6 +266,7 @@ [Components.common] >> > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { >> > >> > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf >> > + >> > NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf >> > # don't use unaligned CopyMem () on the UEFI varstore NOR flash >> > region >> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> > } >> > @@ -326,7 +328,11 @@ [Components.common] >> > # >> > # Bds >> > # >> > - MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> > + MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf { >> > + >> > + >> > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf >> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> > + } >> > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> > >> > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf >> > -- >> > 2.17.0 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > -- > Regards, > Moorthy