From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22b; helo=mail-io0-x22b.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 80C762215BD98 for ; Thu, 1 Feb 2018 00:12:29 -0800 (PST) Received: by mail-io0-x22b.google.com with SMTP id z6so18250142iob.11 for ; Thu, 01 Feb 2018 00:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IC/ckztF5PsgKUDitMnRZAY/vBWcHMTMp0WkoIucCtI=; b=YuwFSdJ2GsKg6IazeIIftI8o9zTaEQeHmiAE2cOexOU+RU8r7ZKV0RkN4zg99eZVHN Z+k3GeE8qJnA8G6ae1Iwf55GXYA5e0In148ts2Xuo/ZI3JdyiY3m/YkMDpQErULdw9Pq RnumKAOKvoUMCozCYh3hQbJ0YKZsiEzqJnPNI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IC/ckztF5PsgKUDitMnRZAY/vBWcHMTMp0WkoIucCtI=; b=Q6E7OKbj++bn5W08RIUmx9uqgM1mpbfuFpx7Ir+/hHYDLA4ijoaE2elU7fkVcV6RhD qQ9CaEOX8MOkDyQuHb70NyOUvixKUQv6V1WtV01c65Z63dktmO6NJmOQz8qp6Hy8/l8U QZVq3A36/WwkNJd7mrqQdf+brGHYu2ao2ffSiWOPCG4at6iNrQ2cadihTG3R6G8UQvtA YAphY3JV8myIvoDIssXez8OJznN2Za+jH5z6B/vK1FR6gSu3DOoc2ZPsxiqA44LUV4Lm b6G1Cjx9hHKffaKDrot8zyV4odbg2fye8SVRvf7aX9aBwtxm/Rr2fRrDzhRcmc4m9+a4 V0SQ== X-Gm-Message-State: AKwxytdtaCLu7t5LyBOAwokJD+GjeXnzxG1VPCSFlrQOCjbQ68OIFxMd oyHvyN4aIBsRoglDdyH8a/EkU6j7k6NZr/EibHPdzg== X-Google-Smtp-Source: AH8x225Oj+6ltKiR9OqMsg9twaxRBTw/9mZVEibAXMDbgl76XkhVv0oxg5OTgDiJsE3ri41M3hScH/XTMnl+TE/gOXI= X-Received: by 10.107.6.161 with SMTP id f33mr40010334ioi.196.1517473085464; Thu, 01 Feb 2018 00:18:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Thu, 1 Feb 2018 00:18:05 -0800 (PST) In-Reply-To: References: <1517389417-25112-1-git-send-email-liming.gao@intel.com> From: Ard Biesheuvel Date: Thu, 1 Feb 2018 08:18:05 +0000 Message-ID: To: "Zhu, Yonghong" Cc: "Gao, Liming" , "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 08:12:30 -0000 Content-Type: text/plain; charset="UTF-8" On 31 January 2018 at 10:39, Zhu, Yonghong wrote: > Reviewed-by: Yonghong Zhu > This patch breaks the GCC build. PcdValueCommon.c: In function '__PcdGetPtr': PcdValueCommon.c:315:11: error: variable 'Byte' set but not used [-Werror=unused-but-set-variable] UINT8 Byte; ^~~~ > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > Sent: Wednesday, January 31, 2018 5:04 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools CommonLib: Remove the unnecessary print message in PcdValueCommon > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > --- > BaseTools/Source/C/Common/PcdValueCommon.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/BaseTools/Source/C/Common/PcdValueCommon.c b/BaseTools/Source/C/Common/PcdValueCommon.c > index 92328da..210f87b 100644 > --- a/BaseTools/Source/C/Common/PcdValueCommon.c > +++ b/BaseTools/Source/C/Common/PcdValueCommon.c > @@ -330,9 +330,7 @@ Returns: > break; > case PcdDataTypePointer: > Value = &PcdList[Index].Value[1]; > - printf ("Value = %s\n", PcdList[Index].Value); > for (*Size = 0, Byte = (UINT8) strtoul(Value, &End, 16); Value != End; Byte = (UINT8) strtoul(Value, &End, 16), *Size = *Size + 1) { > - printf("%x\n", Byte); > Value = End + 1; > } > Buffer = malloc(*Size + 1); > @@ -401,7 +399,6 @@ Returns: > PcdList[Index].Value = malloc(Size * 5 + 3); > PcdList[Index].Value[0] = '{'; > for (ValueIndex = 0; ValueIndex < Size; ValueIndex++) { > - printf("Value[%d] = %02x\n", ValueIndex, Value[ValueIndex]); > sprintf(&PcdList[Index].Value[1 + ValueIndex * 5], "0x%02x,", Value[ValueIndex]); > } > PcdList[Index].Value[1 + Size * 5 - 1] = '}'; @@ -724,15 +721,11 @@ Returns: > if (*InputFileName == NULL) { > fprintf (stderr, "Missing option. Input files is not specified\n"); > exit (EXIT_FAILURE); > - } else { > - printf ("Input file name is %s\n", *InputFileName); > } > > if (*OutputFileName == NULL) { > fprintf (stderr, "Missing option. Output file is not specified\n"); > exit (EXIT_FAILURE); > - } else { > - printf ("Output file name is %s\n", *OutputFileName); > } > } > > @@ -761,7 +754,6 @@ Returns: > UINT8 *FileBuffer; > UINT32 FileSize; > > - printf ("PCD tool start.\n"); > InputFileName = NULL; > OutputFileName = NULL; > > @@ -790,7 +782,5 @@ Returns: > // > WriteOutputFile (OutputFileName); > > - printf ("PCD tool done.\n"); > - > exit (EXIT_SUCCESS); > } > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel